mirror of
https://github.com/Termix-SSH/Termix.git
synced 2026-10-28 14:15:24 +00:00
* fix(sso): send the PKCE verifier for GitHub login (#1534) * fix(remote-desktop): clip cursor overflow without disabling zoom (#1535) * test(remote-desktop): preserve sessions beyond one hour (#1536) * fix(hosts): expose controls for overflowing editor tabs (#1537) * fix(hosts): expose controls for overflowing editor tabs * test(hosts): mock resize observation in admin panel tests * fix(status): skip TCP probes while host sessions are active (#1538) * fix(database): batch session activity persistence (#1539) * docs(api): describe cookie and API key authentication (#1540) * fix(snippets): repair missing note column on SQLite upgrades (#1541) * fix(docker): retain stored SSH credential association (#1543) * fix(file-manager): render transfer toasts without plugin hooks (#1546) * feat(hosts): keep compact row actions inline (#1547) * fix(auth): allow retrying unavailable second-factor interfaces (#1549) * fix(auth): reject unresolved legacy identity provisioning (#1550) * fix(desktop): ship the plugin SDK inside Mac App Store builds (#1551) * fix(tmux): pass full session info to the terminal's session picker (#1552) The tmux.sessions service reduced detected sessions to bare names, but the picker reads session.name, so every entry rendered blank and selecting one sent an empty name, which created a new session instead of attaching. * fix(ssh): read force keyboard-interactive as a boolean when resolving hosts (#1553) The column holds the text "true"/"false", and the resolver passed it through as-is. The string "false" is truthy, so the password provider treated every saved host as forced keyboard-interactive and left the password out. Jump hops are built straight from the resolved host, so a password hop whose server doesn't offer keyboard-interactive failed with "All configured authentication methods failed". * fix(database): batch database saves for bulk host writes (#1554) * fix(database): yield to the event loop between database saves Each SQLite save serializes and encrypts the whole database into new buffers, which V8 only releases once the event loop turns. Boot migrations and bulk host import write plugin settings per host and per key in an awaited loop, so hundreds of full copies piled up and the container ran out of memory. * fix(database): save once per bulk host write instead of once per row On SQLite every repository write force-saves the whole database. Boot plugin data migrations, host defaults materialization and the bulk host routes write one row per host per setting, so they serialized and encrypted the full database hundreds of times in a row. DatabaseSaveTrigger.batched wraps a function so force saves made while it runs collapse into a single save when it finishes. Nested scopes fold into the outer one, and work that outlives its scope saves normally. * feat(hosts): add instance-wide predefined tag suggestions (#1548) * feat(hosts): add shared predefined tag suggestions * style(hosts): format tag catalog routes * test(database): advance fake timers past the save yield (#1555) * fix(i18n): complete Simplified Chinese core and plugin translations (#1542) * fix(i18n): complete Chinese onboarding and navigation labels * fix(i18n): translate remaining Chinese core and plugin interfaces * fix(i18n): translate host editor tab overflow controls * fix(i18n): use consistent Chinese fleet terminology * fix(i18n): localize hardcoded controls and plugin views * fix(i18n): translate built-in homepage widget catalog * test(homepage): follow translated timezone placeholder * fix(i18n): translate plugin-provided homepage widgets * fix(i18n): localize feature settings section titles * fix: 2.8 oidc accounts unable to sign in after upgrading (#1381) * fix: plugins losing the saved ssh login when copying a host (#1391) * fix: fleets, proxmox and automations not getting the host sudo password * fix: host imports running a defaults pass and metrics restart per host (#1384) * fix: high cpu from status probes and full database saves on every sample (#1300) * fix: user data export freezing the server (#1393) * fix: op:// secret references rejected as ssh keys on credentials (#1394) * fix: slow file deletes from the trash lookups on every delete (#1390) * fix: add openapi docs and error handling to host tag routes * test: compare download stream buffers directly so it stops timing out * chore: drop em dash from host row comment * chore: update release notes for 2.9.1 * fix: restore space to add host tags and redesign predefined tags editor * fix: host key silently accepted when the host is missing from the database (#1397) * fix: clearer host login failed status label and fix its translations (#1396) * chore: add host key and status label fixes to release notes * fix: sso and ldap provider dialogs overflowing the screen and using mismatched toggles * chore: increment ver * fix(audit): store plugin entries with no acting user as a null user_id (#1556) Plugin audit entries written outside a request used the literal "system" as user_id. That column references users.id, so the insert was refused (Postgres logs it as an FK violation) and the entry was silently dropped. Write null instead and keep "system" / plugin:<id> in username. * chore: add sso/ldap dialog and audit log fixes to release notes * fix: tunnels and host settings missing from shared hosts on desktop * fix: remote desktop logins missing from shared hosts on desktop * fix: simplify host status to online/offline and keep it live without a refresh * chore: sync Crowdin translations for 2.9.1 --------- Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com>
198 lines
6.4 KiB
TypeScript
198 lines
6.4 KiB
TypeScript
/**
|
|
* A user's rows in plugin tables travel with their export and come back on
|
|
* import, found through the table definitions plugins registered rather than
|
|
* any table name core knows.
|
|
*/
|
|
|
|
import Database from "better-sqlite3";
|
|
import { drizzle } from "drizzle-orm/better-sqlite3";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import {
|
|
defineTable,
|
|
encryptedText,
|
|
id,
|
|
refHost,
|
|
refUser,
|
|
text,
|
|
varchar,
|
|
} from "@termix/plugin-sdk/db";
|
|
|
|
let sqlite: Database.Database;
|
|
|
|
vi.mock("../../database/db/index.js", () => ({
|
|
getDb: () => drizzle(sqlite),
|
|
}));
|
|
vi.mock("../../utils/logger.js", () => ({
|
|
pluginLogger: {
|
|
debug: vi.fn(),
|
|
info: vi.fn(),
|
|
warn: vi.fn(),
|
|
error: vi.fn(),
|
|
},
|
|
}));
|
|
|
|
const { registerTable, resetPluginData } =
|
|
await import("../../plugins/data.js");
|
|
const {
|
|
importUserPluginRows,
|
|
listUserOwnedTables,
|
|
readUserPluginRows,
|
|
writeUserPluginTables,
|
|
} = await import("../../plugins/user-data.js");
|
|
const { createTableSql } = await import("../../plugins/table-builder.js");
|
|
|
|
// Stands for an adopted table; adoptLegacyTable only accepts real core names.
|
|
const bookmarks = {
|
|
...defineTable("bookmark", {
|
|
id: id(),
|
|
userId: refUser(),
|
|
path: varchar(200).notNull(),
|
|
note: text(),
|
|
token: encryptedText(),
|
|
}),
|
|
adopts: "bookmarks_legacy",
|
|
};
|
|
const shared = defineTable("shared_thing", { id: id(), label: text() });
|
|
|
|
function createTables(target: Database.Database) {
|
|
target.exec("CREATE TABLE users (id TEXT PRIMARY KEY)");
|
|
target.exec("CREATE TABLE ssh_data (id INTEGER PRIMARY KEY)");
|
|
for (const definition of [bookmarks, shared]) {
|
|
for (const statement of createTableSql("sqlite", "fixture", definition)) {
|
|
target.exec(statement);
|
|
}
|
|
}
|
|
}
|
|
|
|
beforeEach(() => {
|
|
sqlite = new Database(":memory:");
|
|
createTables(sqlite);
|
|
sqlite.exec("INSERT INTO users (id) VALUES ('u1'), ('u2')");
|
|
sqlite.exec(`INSERT INTO p_fixture_bookmark (user_id, path, note, token)
|
|
VALUES ('u1', '/etc', 'config', 'sealed'), ('u2', '/var', null, null)`);
|
|
registerTable("fixture", bookmarks);
|
|
registerTable("fixture", shared);
|
|
});
|
|
|
|
afterEach(() => {
|
|
resetPluginData();
|
|
sqlite.close();
|
|
});
|
|
|
|
describe("plugin user data", () => {
|
|
it("lists only tables with a user column, without keys or secrets", () => {
|
|
const [owned] = listUserOwnedTables();
|
|
expect(listUserOwnedTables()).toHaveLength(1);
|
|
expect(owned).toMatchObject({
|
|
pluginId: "fixture",
|
|
table: "p_fixture_bookmark",
|
|
legacyName: "bookmarks_legacy",
|
|
userColumn: "user_id",
|
|
columns: ["user_id", "path", "note"],
|
|
});
|
|
});
|
|
|
|
it("reads one user's rows", async () => {
|
|
expect(await readUserPluginRows("u1")).toEqual({
|
|
p_fixture_bookmark: [{ user_id: "u1", path: "/etc", note: "config" }],
|
|
});
|
|
});
|
|
|
|
it("round-trips through an export file into another user", async () => {
|
|
// The export file has the user row, as database.ts writes it first.
|
|
const file = new Database(":memory:");
|
|
file.exec("CREATE TABLE users (id TEXT PRIMARY KEY)");
|
|
file.exec("CREATE TABLE ssh_data (id INTEGER PRIMARY KEY)");
|
|
file.exec("INSERT INTO users (id) VALUES ('u1')");
|
|
expect(await writeUserPluginTables(file, "u1")).toBe(1);
|
|
|
|
sqlite.exec("DELETE FROM p_fixture_bookmark");
|
|
const result = await importUserPluginRows(file, "u2");
|
|
expect(result).toEqual({ imported: 1, skipped: 0, errors: [] });
|
|
expect(
|
|
sqlite.prepare("SELECT user_id, path FROM p_fixture_bookmark").all(),
|
|
).toEqual([{ user_id: "u2", path: "/etc" }]);
|
|
|
|
const again = await importUserPluginRows(file, "u2");
|
|
expect(again).toMatchObject({ imported: 0, skipped: 1 });
|
|
});
|
|
|
|
it("writes large tables in chunks and lets the event loop run between them", async () => {
|
|
const insert = sqlite.prepare(
|
|
"INSERT INTO p_fixture_bookmark (user_id, path) VALUES ('u1', ?)",
|
|
);
|
|
sqlite.transaction(() => {
|
|
for (let i = 0; i < 4999; i++) insert.run(`/p/${i}`);
|
|
})();
|
|
const file = new Database(":memory:");
|
|
file.exec("CREATE TABLE users (id TEXT PRIMARY KEY)");
|
|
file.exec("CREATE TABLE ssh_data (id INTEGER PRIMARY KEY)");
|
|
file.exec("INSERT INTO users (id) VALUES ('u1')");
|
|
const transaction = vi.spyOn(file, "transaction");
|
|
let ticks = 0;
|
|
const ticker = setInterval(() => ticks++, 0);
|
|
|
|
const written = await writeUserPluginTables(file, "u1");
|
|
clearInterval(ticker);
|
|
|
|
expect(written).toBe(5000);
|
|
expect(transaction).toHaveBeenCalled();
|
|
expect(ticks).toBeGreaterThan(0);
|
|
expect(
|
|
file.prepare("SELECT COUNT(*) AS n FROM p_fixture_bookmark").get(),
|
|
).toEqual({ n: 5000 });
|
|
});
|
|
|
|
it("reads a pre-2.9 export by the legacy table name", async () => {
|
|
const file = new Database(":memory:");
|
|
file.exec(
|
|
"CREATE TABLE bookmarks_legacy (id INTEGER PRIMARY KEY, user_id TEXT, path TEXT, note TEXT)",
|
|
);
|
|
file.exec(
|
|
"INSERT INTO bookmarks_legacy (user_id, path, note) VALUES ('old', '/srv', 'x')",
|
|
);
|
|
const result = await importUserPluginRows(file, "u1");
|
|
expect(result.imported).toBe(1);
|
|
expect(
|
|
sqlite
|
|
.prepare(
|
|
"SELECT user_id, note FROM p_fixture_bookmark WHERE path = '/srv'",
|
|
)
|
|
.get(),
|
|
).toEqual({ user_id: "u1", note: "x" });
|
|
});
|
|
|
|
it("skips imported rows that point at another user or host", async () => {
|
|
sqlite.exec("DROP TABLE ssh_data");
|
|
sqlite.exec("CREATE TABLE ssh_data (id INTEGER PRIMARY KEY, user_id TEXT)");
|
|
sqlite.exec(
|
|
"INSERT INTO ssh_data (id, user_id) VALUES (1, 'u2'), (2, 'u1')",
|
|
);
|
|
const grants = defineTable("grant", {
|
|
id: id(),
|
|
ownerId: refUser(),
|
|
granteeId: refUser(),
|
|
hostId: refHost(),
|
|
});
|
|
for (const statement of createTableSql("sqlite", "fixture", grants)) {
|
|
sqlite.exec(statement);
|
|
}
|
|
registerTable("fixture", grants);
|
|
|
|
const file = new Database(":memory:");
|
|
file.exec(
|
|
"CREATE TABLE p_fixture_grant (id INTEGER PRIMARY KEY, owner_id TEXT, grantee_id TEXT, host_id INTEGER)",
|
|
);
|
|
file.exec(`INSERT INTO p_fixture_grant (owner_id, grantee_id, host_id) VALUES
|
|
('old', 'old', 1), ('old', 'u1', 1), ('old', 'old', 2)`);
|
|
|
|
const result = await importUserPluginRows(file, "u2");
|
|
expect(result).toMatchObject({ imported: 1, skipped: 2 });
|
|
expect(
|
|
sqlite
|
|
.prepare("SELECT owner_id, grantee_id, host_id FROM p_fixture_grant")
|
|
.all(),
|
|
).toEqual([{ owner_id: "u2", grantee_id: "u2", host_id: 1 }]);
|
|
});
|
|
});
|