fix: prefer ipv4 when resolving ssh host names (#1365)

src/backend/tests/hosts/ssh-dns.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, it, vi } from "vitest";
 import {
   isRetriableDnsError,
+  pickSshAddress,
   resolveHostForSshConnect,
   resolveSshConnectConfigHost,
   shouldResolveBeforeSshConnect,
@@ -76,4 +77,25 @@ describe("SSH DNS resolution", () => {
       resolvedHost: "10.0.0.6",
     });
   });
+
+  it("prefers an IPv4 address when a name has both", async () => {
+    const lookup = vi.fn().mockResolvedValue([
+      { address: "::1", family: 6 },
+      { address: "10.0.0.7", family: 4 },
+    ]);
+
+    await expect(resolveHostForSshConnect("box", lookup)).resolves.toEqual({
+      host: "10.0.0.7",
+      resolvedAddress: "10.0.0.7",
+      attempts: 1,
+    });
+    expect(lookup).toHaveBeenCalledWith("box", { all: true });
+  });
+
+  it("falls back to IPv6 when that is all there is", () => {
+    expect(pickSshAddress([{ address: "2001:db8::2", family: 6 }])).toBe(
+      "2001:db8::2",
+    );
+    expect(() => pickSshAddress([])).toThrow();
+  });
 });