fix: readable terminal selection with the light theme (#1319)

plugins/ssh-terminal/src/frontend/look/terminal-theme.ts

@@ -41,7 +41,10 @@ export function resolveTermixThemeColors(
   }
   const uiColors =
     TERMIX_DEFAULT_COLORS[resolvedUiTheme] ?? TERMIX_DEFAULT_COLORS.dark;
-  const base = TERMINAL_THEMES.termixDark.colors;
+  const base =
+    resolvedUiTheme === "light"
+      ? TERMINAL_THEMES.termixLight.colors
+      : TERMINAL_THEMES.termixDark.colors;
   return {
     ...base,
     background: uiColors.background,

plugins/ssh-terminal/tests/frontend/look/terminal-theme.test.ts

@@ -0,0 +1,21 @@
+import { describe, expect, it } from "vitest";
+import { resolveTermixThemeColors } from "../../../src/frontend/look/terminal-theme";
+import { TERMINAL_THEMES } from "../../../src/frontend/look/terminal-themes";
+
+describe("resolveTermixThemeColors", () => {
+  it("uses the light selection color with the light UI theme", () => {
+    const colors = resolveTermixThemeColors("termix", "light");
+    expect(colors.background).toBe("#ffffff");
+    expect(colors.selectionBackground).toBe(
+      TERMINAL_THEMES.termixLight.colors.selectionBackground,
+    );
+  });
+
+  it("keeps the dark selection color with dark UI themes", () => {
+    const colors = resolveTermixThemeColors("termix", "dracula");
+    expect(colors.background).toBe("#282a36");
+    expect(colors.selectionBackground).toBe(
+      TERMINAL_THEMES.termixDark.colors.selectionBackground,
+    );
+  });
+});