feat(hosts): keep compact row actions inline (#1547)

This commit is contained in:
ZacharyZcR authored and GitHub committed 2026-10-03 21:02:54 +08:00
1 parent 2c4de5f705
commit c66702deb1
2 files changed
+74 -50

No files matched your search

+73 -50
View File
@@ -1096,7 +1096,10 @@ export function HostItem({
className={`flex flex-col flex-1 min-w-0 ${tokens.rowPadding} ${isCompact ? "" : "gap-[3.5px]"}`}
>
{/* Name row */}
<div data-drag-label className="flex items-center gap-1.5 min-w-0">
<div
data-drag-label
className={`flex items-center gap-1.5 min-w-0 ${isCompact ? "min-h-[19px]" : ""}`}
>
{onToggleExpand && (
<button
type="button"
@@ -1190,6 +1193,23 @@ export function HostItem({
{host.ip}
</span>
)}
{isCompact && !selectionMode && (
<div
data-testid="host-inline-actions"
className={`flex items-center gap-[2px] min-w-0 max-w-[60%] overflow-x-auto [scrollbar-width:none] [&::-webkit-scrollbar]:hidden [&>*]:shrink-0 ${alwaysShowTray || actionsOnly || trayOpenState || hoverTrayOpen ? "" : "hidden"}`}
>
{connectionButtons}
<div
className={
alwaysShowTray || trayOpenState || hoverTrayOpen
? "flex items-center gap-[2px]"
: "hidden"
}
>
{managementButtons}
</div>
</div>
)}
{!selectionMode && (shouldUseClickTray || actionsOnly) && (
<button
title={
@@ -1239,7 +1259,8 @@ export function HostItem({
)}
{/* Connection buttons: permanent in "always"/"actionsOnly" modes, or shown once the chevron opens the tray in click mode */}
{!selectionMode &&
{!isCompact &&
!selectionMode &&
(alwaysShowTray ||
actionsOnly ||
(shouldUseClickTray && isTrayOpen)) && (
@@ -1251,61 +1272,63 @@ export function HostItem({
)}
{/* Action tray — slides open on hover (default) or via chevron in click-tray mode */}
<div className={trayVisibilityClass}>
{tokens.showResourceRow &&
isOnline &&
((host.cpu != null && host.cpu > 0) ||
(host.ram != null && host.ram > 0)) && (
<div className="flex items-center gap-[10.5px] pt-[5.25px]">
{host.cpu != null && host.cpu > 0 && (
<div className="flex items-center gap-1.5">
<Cpu className="size-2.5 shrink-0 text-muted-foreground/40" />
<div className="w-9 h-1 bg-muted-foreground/15 rounded-full overflow-hidden">
<div
className={`motion-meter h-full rounded-full ${host.cpu > 80 ? "bg-red-400" : host.cpu > 50 ? "bg-yellow-400" : "bg-accent-brand"}`}
style={{ width: `${host.cpu}%` }}
/>
{!isCompact && (
<div className={trayVisibilityClass}>
{tokens.showResourceRow &&
isOnline &&
((host.cpu != null && host.cpu > 0) ||
(host.ram != null && host.ram > 0)) && (
<div className="flex items-center gap-[10.5px] pt-[5.25px]">
{host.cpu != null && host.cpu > 0 && (
<div className="flex items-center gap-1.5">
<Cpu className="size-2.5 shrink-0 text-muted-foreground/40" />
<div className="w-9 h-1 bg-muted-foreground/15 rounded-full overflow-hidden">
<div
className={`motion-meter h-full rounded-full ${host.cpu > 80 ? "bg-red-400" : host.cpu > 50 ? "bg-yellow-400" : "bg-accent-brand"}`}
style={{ width: `${host.cpu}%` }}
/>
</div>
<span className="text-[9px] tabular-nums text-muted-foreground/50">
{host.cpu}%
</span>
</div>
<span className="text-[9px] tabular-nums text-muted-foreground/50">
{host.cpu}%
</span>
</div>
)}
{host.ram != null && host.ram > 0 && (
<div className="flex items-center gap-1.5">
<MemoryStick className="size-2.5 shrink-0 text-muted-foreground/40" />
<div className="w-9 h-1 bg-muted-foreground/15 rounded-full overflow-hidden">
<div
className={`motion-meter h-full rounded-full ${host.ram > 80 ? "bg-red-400" : host.ram > 60 ? "bg-yellow-400" : "bg-accent-brand/60"}`}
style={{ width: `${host.ram}%` }}
/>
)}
{host.ram != null && host.ram > 0 && (
<div className="flex items-center gap-1.5">
<MemoryStick className="size-2.5 shrink-0 text-muted-foreground/40" />
<div className="w-9 h-1 bg-muted-foreground/15 rounded-full overflow-hidden">
<div
className={`motion-meter h-full rounded-full ${host.ram > 80 ? "bg-red-400" : host.ram > 60 ? "bg-yellow-400" : "bg-accent-brand/60"}`}
style={{ width: `${host.ram}%` }}
/>
</div>
<span className="text-[9px] tabular-nums text-muted-foreground/50">
{host.ram}%
</span>
</div>
<span className="text-[9px] tabular-nums text-muted-foreground/50">
{host.ram}%
</span>
</div>
)}
</div>
)}
)}
</div>
)}
<div
className={`flex flex-col gap-0.5 ${alwaysShowTray || actionsOnly || shouldUseClickTray ? "" : "pt-1.5"}`}
>
{/* Connection buttons — only shown here when not already shown above */}
{!alwaysShowTray && !actionsOnly && !shouldUseClickTray && (
<div className="flex items-center flex-wrap gap-[1.75px]">
{connectionButtons}
</div>
)}
{/* Management buttons row */}
<div
className={`flex items-center gap-[1.75px] border-t border-border/30 ${alwaysShowTray || actionsOnly || shouldUseClickTray ? "pt-[5.25px]" : "pt-[3.5px] mt-[1.75px]"}`}
className={`flex flex-col gap-0.5 ${alwaysShowTray || actionsOnly || shouldUseClickTray ? "" : "pt-1.5"}`}
>
{managementButtons}
{/* Connection buttons — only shown here when not already shown above */}
{!alwaysShowTray && !actionsOnly && !shouldUseClickTray && (
<div className="flex items-center flex-wrap gap-[1.75px]">
{connectionButtons}
</div>
)}
{/* Management buttons row */}
<div
className={`flex items-center gap-[1.75px] border-t border-border/30 ${alwaysShowTray || actionsOnly || shouldUseClickTray ? "pt-[5.25px]" : "pt-[3.5px] mt-[1.75px]"}`}
>
{managementButtons}
</div>
</div>
</div>
</div>
)}
{authOverrideProtocol && (
<HostAuthOverrideModal
open
+1
View File
@@ -754,6 +754,7 @@ export function SidebarTree({
const row = visibleRows[index];
if (!row) return FOLDER_ROW_HEIGHT;
if (isFolder(row.item)) return FOLDER_ROW_HEIGHT;
if (isCompactDensity) return 29;
const tagExtra = showTags && row.item.tags?.length ? TAG_ROW_EXTRA : 0;
// The resource bars only render for an online host that reported CPU/RAM.
// Reserving their height unconditionally left a gap under every offline