feat: store rdp, vnc and telnet logins in a generic per-protocol table

plugins/remote-desktop/tests/backend/host-settings.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 import {
+  hostPayloadLegacy,
   normalizeImportedHost,
   userDefaultParams,
 } from "../../src/backend/host-settings.js";
@@ -80,3 +81,38 @@ describe("userDefaultParams", () => {
     });
   });
 });
+
+describe("hostPayloadLegacy", () => {
+  it("puts each login back in its 2.8 flat shape for older clients", () => {
+    expect(
+      hostPayloadLegacy(
+        {},
+        {
+          protocolAuth: {
+            rdp: {
+              authType: "direct",
+              credentialId: null,
+              username: "admin",
+              fields: { domain: "CORP" },
+              hasPassword: true,
+            },
+            vnc: { authType: "credential", credentialId: 4 },
+          },
+        },
+      ),
+    ).toEqual({
+      rdpAuthType: "direct",
+      rdpCredentialId: null,
+      rdpUser: "admin",
+      hasRdpPassword: true,
+      rdpDomain: "CORP",
+      domain: "CORP",
+      vncAuthType: "credential",
+      vncCredentialId: 4,
+    });
+  });
+
+  it("adds nothing for a host without logins", () => {
+    expect(hostPayloadLegacy({}, {})).toBeNull();
+  });
+});

plugins/remote-desktop/tests/backend/routes.test.ts

@@ -37,7 +37,7 @@ function target(
       authType: "direct",
       username: "admin",
       password: "secret",
-      domain: "CORP",
+      fields: { domain: "CORP" },
       ...overrides,
     },
   };