feat: redesign user host defaults system

plugins/ssh-terminal/tests/frontend/activate.test.tsx

@@ -116,11 +116,11 @@ describe(`${manifest.id} activate`, () => {
   it("registers its settings components", async () => {
     rendered = await renderWithApp(plugin, { manifest, locales });
     expect(rendered.registered.settingsComponents()).toEqual(
-      expect.arrayContaining([
-        "terminalDefaults",
-        "newHostTheme",
-        "newHostFontFamily",
-      ]),
+      expect.arrayContaining(["touchInput", "imageStorageTest"]),
+    );
+    // Terminal defaults are host defaults now, set in the host editor.
+    expect(rendered.registered.settingsComponents()).not.toContain(
+      "terminalDefaults",
     );
   });
 

plugins/ssh-terminal/tests/frontend/settings/TerminalDefaultsSettings.test.tsx

@@ -1,37 +0,0 @@
-import { afterEach, describe, expect, it, vi } from "vitest";
-import { cleanup, fireEvent, render, screen } from "@testing-library/react";
-import { TerminalDefaultsSettings } from "../../../src/frontend/settings/TerminalDefaultsSettings";
-
-afterEach(cleanup);
-
-describe("TerminalDefaultsSettings", () => {
-  it("counts the defaults the user set", () => {
-    render(
-      <TerminalDefaultsSettings
-        pluginId="ssh-terminal"
-        values={{ terminalDefaults: { fontSize: 18, cursorBlink: false } }}
-        setValue={vi.fn()}
-        running
-      />,
-    );
-    expect(screen.getByText("2")).toBeTruthy();
-  });
-
-  it("applies the dialog's values to the terminalDefaults setting", () => {
-    const setValue = vi.fn();
-    render(
-      <TerminalDefaultsSettings
-        pluginId="ssh-terminal"
-        values={{ terminalDefaults: { fontSize: 18 } }}
-        setValue={setValue}
-        running
-      />,
-    );
-    fireEvent.click(screen.getByText("terminalDefaults.manage"));
-    fireEvent.change(screen.getByDisplayValue("18"), {
-      target: { value: "20" },
-    });
-    fireEvent.click(screen.getByText("terminalDefaults.apply"));
-    expect(setValue).toHaveBeenCalledWith("terminalDefaults", { fontSize: 20 });
-  });
-});

plugins/ssh-terminal/tests/frontend/settings/tri-state.test.ts

@@ -1,17 +0,0 @@
-import { describe, expect, it } from "vitest";
-import {
-  fromTriState,
-  toTriState,
-} from "../../../src/frontend/settings/tri-state";
-
-describe("tri-state", () => {
-  it("keeps unset booleans distinct from false", () => {
-    expect(toTriState(undefined)).toBe("inherit");
-    expect(toTriState(true)).toBe("on");
-    expect(toTriState(false)).toBe("off");
-
-    expect(fromTriState("inherit")).toBeUndefined();
-    expect(fromTriState("on")).toBe(true);
-    expect(fromTriState("off")).toBe(false);
-  });
-});