feat: redesign user host defaults system

plugins/ssh-terminal/tests/backend/host-import.test.ts

@@ -54,8 +54,9 @@ describe("hostPayloadLegacy", () => {
       fontSize: 20,
     }) as { terminalConfig: Record<string, unknown> };
     expect(terminalConfig.autoTmux).toBe(true);
-    expect(terminalConfig).not.toHaveProperty("fontSize");
-    expect(terminalConfig).not.toHaveProperty("localEcho");
+    // The values already follow the host defaults, so the look is included.
+    expect(terminalConfig.fontSize).toBe(20);
+    expect(terminalConfig.localEcho).toBe("auto");
   });
 
   it("includes the look of a host that has its own", () => {

plugins/ssh-terminal/tests/backend/routes.test.ts

@@ -146,26 +146,20 @@ describe("terminal settings routes", () => {
     authType: "password",
   });
 
-  it("hands every user their own terminal settings and the new-host defaults", async () => {
-    server = await startServer({
-      settings: { newHostFontSize: 20, newHostTheme: "nord" },
-    });
+  it("hands every user their own terminal settings", async () => {
+    server = await startServer();
     await server.mock.ctx.settings.setUser(
       "user-1",
       "commandAutocomplete",
       true,
     );
-    await server.mock.ctx.settings.setUser("user-1", "terminalDefaults", {
-      fontSize: 18,
-    });
     const { body } = await server.request("GET", "/client-settings");
     expect(body.user).toMatchObject({
       commandAutocomplete: true,
-      terminalDefaults: { fontSize: 18 },
       localEcho: "auto",
       linkClickBehavior: "confirm",
     });
-    expect(body.newHostDefaults).toMatchObject({ fontSize: 20, theme: "nord" });
+    expect(body).not.toHaveProperty("newHostDefaults");
     const other = await server.request("GET", "/client-settings", {
       user: "user-2",
     });

plugins/ssh-terminal/tests/backend/terminal-settings.test.ts

@@ -30,19 +30,25 @@ describe("hostSettingsFromTerminalConfig", () => {
 });
 
 describe("resolveTerminalSettings", () => {
-  it("uses the user's defaults while the host follows them", () => {
+  it("runs with the host's values, which already follow its defaults", () => {
     const host = readHostTerminalSettings({ fontSize: 30, autoTmux: true });
-    const resolved = resolveTerminalSettings(host, { fontSize: 18 });
-    expect(resolved.fontSize).toBe(18);
+    const resolved = resolveTerminalSettings(host);
+    expect(resolved.fontSize).toBe(30);
     expect(resolved.autoTmux).toBe(true);
   });
 
-  it("uses the host's own look once it opts out", () => {
+  it("ignores the old follow-the-user switch", () => {
     const host = readHostTerminalSettings({
-      inheritAppearance: false,
-      fontSize: 30,
+      inheritAppearance: true,
+      fontSize: 22,
     });
-    expect(resolveTerminalSettings(host, { fontSize: 18 }).fontSize).toBe(30);
+    expect(resolveTerminalSettings(host).fontSize).toBe(22);
+  });
+
+  it("defaults echo and link clicks to concrete modes", () => {
+    const resolved = resolveTerminalSettings(readHostTerminalSettings({}));
+    expect(resolved.localEcho).toBe("auto");
+    expect(resolved.linkClickBehavior).toBe("confirm");
   });
 
   it("falls back to the built-in defaults", () => {
@@ -62,7 +68,6 @@ describe("readUserSettings", () => {
         linkClickBehavior: "direct",
       }),
     ).toEqual({
-      terminalDefaults: { fontSize: 16 },
       customThemes: [{ id: "a", name: "A", colors: {} }],
       commandAutocomplete: false,
       localEcho: "auto",