feat: redesign user host defaults system

plugins/remote-desktop/src/backend/routes.ts

@@ -23,7 +23,7 @@ import {
   PORT_KEY,
   isRemoteProtocol,
   readHostSettings,
-  readUserDefaults,
+  readDisplayDefaults,
   type RemoteProtocol,
 } from "./host-settings.js";
 import { errorMessage, type RemoteDesktopLogger } from "./log.js";
@@ -203,7 +203,7 @@ export function registerRoutes(router: Router, deps: RouteDeps): void {
       const userId = ctx.currentActor();
       if (type === "rdp" && userId) {
         for (const [key, value] of Object.entries(
-          await readUserDefaults(ctx, userId),
+          await readDisplayDefaults(ctx, userId),
         )) {
           if (isServerOwnedSetting(key)) continue;
           if (options[key] === undefined) options[key] = value;
@@ -319,9 +319,11 @@ export function registerRoutes(router: Router, deps: RouteDeps): void {
         });
       }
 
-      // The user's RDP defaults sit under whatever the host sets itself.
+      // The display settings sit under whatever the host's guacd settings say.
       const { config, guacdOverrides } = cleanGuacConfig({
-        ...(protocol === "rdp" ? await readUserDefaults(ctx, userId) : {}),
+        ...(protocol === "rdp"
+          ? await readDisplayDefaults(ctx, userId, hostId)
+          : {}),
         ...settings.guacamoleConfig,
       });
       let guacConfig = config;
@@ -545,7 +547,9 @@ export function registerRoutes(router: Router, deps: RouteDeps): void {
             .json({ error: "Protocol is not enabled for this host" });
         }
         const { guacdOverrides } = cleanGuacConfig({
-          ...(protocol === "rdp" ? await readUserDefaults(ctx, userId) : {}),
+          ...(protocol === "rdp"
+            ? await readDisplayDefaults(ctx, userId, hostId)
+            : {}),
           ...settings.guacamoleConfig,
         });
         guacd = {