v26.10.5 (#1710)

* feat: add an auto or fixed columns picker to card grids

* feat: add safe mode that only runs layout and theme plugins

* docs: add simple layout to plugin table

* fix: ask for local network access in the macOS app

* feat: allow plugin registries on listed private hosts (#1705)

* chore: add private registry hosts to the changelog

* feat: use the proxy for plugin registry downloads

* fix: allow changing connection origin on shared hosts

* chore: update translations and plugin pins

* chore: lint, format, and bump version to 26.10.5

---------

Co-authored-by: Lukas <80832688+0skater0@users.noreply.github.com>

src/backend/plugins/boot-state.ts

@@ -14,3 +14,24 @@ export function startablePluginIds(
       .map((record) => record.id),
   );
 }
+
+/**
+ * Plugins that shipped in an earlier image and were left on, but whose code is
+ * not in this one (a smaller image tag). They get fetched from the registry.
+ */
+export function missingShippedPluginIds(
+  records: { id: string; tier: string; state: string }[],
+  presentIds: ReadonlySet<string>,
+  ignored: ReadonlySet<string>,
+): string[] {
+  return records
+    .filter(
+      (record) =>
+        record.tier === "bundled" &&
+        record.state !== "disabled" &&
+        !presentIds.has(record.id) &&
+        !ignored.has(record.id),
+    )
+    .map((record) => record.id)
+    .sort();
+}

src/backend/plugins/index.ts

@@ -23,6 +23,11 @@ import { setHostProtocolSource } from "../hosts/protocol-auth/registry.js";
 import { setSecretResolverOwnerSource } from "../hosts/connect/secret-resolver-registry.js";
 import { recordConflict } from "./conflicts.js";
 import { startablePluginIds } from "./boot-state.js";
+import {
+  mayRunInSafeMode,
+  safeModeOn,
+  safeModePluginIds,
+} from "./safe-mode.js";
 import { setPluginImpersonationCheck } from "../utils/auth-manager.js";
 import { setKeybindingActionSource } from "../database/routes/keybinding-validation.js";
 
@@ -237,6 +242,10 @@ export async function initializePlugins(
   if (loaded.length === 0) return [];
 
   const fresh = await seedPlugins(loaded, options.freshInstall === true);
+  if (!fresh) {
+    const { restoreMissingPlugins } = await import("./manage.js");
+    loaded.push(...(await restoreMissingPlugins()));
+  }
   await syncCapabilityGrants(loaded);
   if (loaded.some((plugin) => plugin.source === "bundled")) {
     const { offerPluginSetup } = await import("./onboarding.js");
@@ -248,8 +257,17 @@ export async function initializePlugins(
   const records = await createCurrentPluginRepository().listAll();
   const enabled = startablePluginIds(records);
 
+  const safe = safeModeOn() ? safeModePluginIds(loaded) : null;
+  if (safe) {
+    pluginLogger.warn(
+      "Safe mode is on (TERMIX_SAFE_MODE). Only layout and theme plugins start",
+      { operation: "plugin_init" },
+    );
+  }
+
   const candidates = loaded
     .filter((plugin) => enabled.has(plugin.id))
+    .filter((plugin) => !safe || safe.has(plugin.id))
     .map((plugin) => plugin.id);
 
   for (const pluginId of candidates) {
@@ -539,6 +557,8 @@ export async function activatePlugin(pluginId: string): Promise<void> {
   // Before activate: a plugin's own activate() may already want to check one
   // of its permissions.
   const plugin = pluginLoader.get(pluginId);
+  // Stays enabled and starts on the next boot without safe mode.
+  if (!mayRunInSafeMode(pluginId, pluginLoader.list())) return;
   if (plugin) await registerPluginPermissions(plugin);
 
   await pluginLoader.activate(pluginId);

src/backend/plugins/manage.ts

@@ -18,6 +18,7 @@ import path from "node:path";
 import semver from "semver";
 import { pluginLogger } from "../utils/logger.js";
 import { isDefaultLookPlugin } from "./bundled-index.js";
+import { mayRunInSafeMode } from "./safe-mode.js";
 import {
   activatePlugin,
   deactivatePlugin,
@@ -25,6 +26,7 @@ import {
   registerLoadedPlugins,
   unloadPlugin,
 } from "./index.js";
+import { missingShippedPluginIds } from "./boot-state.js";
 import type { LoadedPlugin, PluginLoader } from "./loader.js";
 import {
   getBundledPluginsDir,
@@ -763,6 +765,13 @@ export async function setPluginStateUnlocked(
   if (!loader.get(pluginId)) {
     throw new PluginManageError("Plugin not found", 404, "NOT_FOUND");
   }
+  if (enabled && !mayRunInSafeMode(pluginId, loader.list())) {
+    throw new PluginManageError(
+      "Safe mode is on, so only layout and theme plugins can start",
+      409,
+      "SAFE_MODE",
+    );
+  }
   const plan = await planStateChange(pluginId, enabled);
 
   if (enabled) {
@@ -959,7 +968,11 @@ export function installPlugin(
   return serialized(async () => {
     const { createCurrentPluginRepository } = await repos();
     const repository = createCurrentPluginRepository();
-    if (await repository.findById(pluginId)) {
+    // A record with no code is a plugin an older image shipped: install fills it in.
+    if (
+      (await repository.findById(pluginId)) &&
+      getPluginRuntime().loader.get(pluginId)
+    ) {
       throw new PluginManageError(
         "Plugin is already installed",
         409,
@@ -1018,6 +1031,63 @@ export function installPlugin(
   });
 }
 
+/**
+ * Called at boot before plugins start. A plugin the database has on but the
+ * image no longer ships (an update to a smaller image tag) is fetched from the
+ * official registry, so nothing an install used goes missing. One that cannot
+ * be fetched stays as it was and is tried again on the next start.
+ */
+export function restoreMissingPlugins(): Promise<LoadedPlugin[]> {
+  return serialized(async () => {
+    const { createCurrentPluginRepository } = await repos();
+    const repository = createCurrentPluginRepository();
+    const { loader } = getPluginRuntime();
+    const ids = missingShippedPluginIds(
+      await repository.listAll(),
+      new Set(loader.list().map((plugin) => plugin.id)),
+      await readUninstalled(),
+    );
+    const restored: LoadedPlugin[] = [];
+    for (const id of ids) {
+      try {
+        const record = await repository.findById(id);
+        const { source, release } = await requireRelease(
+          id,
+          record?.pinnedVersion ?? undefined,
+          channelOf(record),
+          OFFICIAL_REGISTRY_ID,
+        );
+        const plugin = await swapIn(id, { release, source });
+        await repository.update(id, {
+          registryId: source.id,
+          tier: tierFor(plugin, source),
+        });
+        await grantDeclared(plugin, null);
+        restored.push(plugin);
+        pluginLogger.info(
+          `Restored ${id}@${release.version} from the registry`,
+          {
+            operation: "plugin_restore_missing",
+          },
+        );
+      } catch (error) {
+        const message = error instanceof Error ? error.message : String(error);
+        pluginLogger.warn(`Could not restore ${id}: ${message}`, {
+          operation: "plugin_restore_missing",
+        });
+        // The registry is down or offline, so the rest would fail the same way.
+        if (
+          error instanceof PluginManageError &&
+          error.code === "REGISTRY_UNREACHABLE"
+        ) {
+          break;
+        }
+      }
+    }
+    return restored;
+  });
+}
+
 export function updatePlugin(
   pluginId: string,
   options: InstallOptions,

src/backend/plugins/registry-index.ts

@@ -12,6 +12,7 @@
 
 import crypto from "node:crypto";
 import fs from "node:fs";
+import { isIP } from "node:net";
 import path from "node:path";
 import semver from "semver";
 import {
@@ -23,7 +24,11 @@ import {
   youtubeVideoId,
 } from "@termix-ssh/plugin-sdk/manifest";
 import { getLocalVersion } from "../utils/app-version.js";
-import { safeOutboundFetch } from "../utils/safe-outbound-fetch.js";
+import {
+  isBlockedAddress,
+  safeOutboundFetch,
+} from "../utils/safe-outbound-fetch.js";
+import { fetchWithProxy, getProxyAgent } from "../utils/proxy-agent.js";
 import { pluginLogger } from "../utils/logger.js";
 import {
   COMMUNITY_PLUGIN_KEYS,
@@ -278,15 +283,72 @@ export function canRunRelease(
   );
 }
 
+/**
+ * Hosts the admin lets registry fetches reach on a private address, like a
+ * registry in the LAN. Matched by host name on any port, also when another
+ * index or a redirect points there; every other host stays blocked.
+ */
+export function getRegistryPrivateHosts(): string[] {
+  return (process.env.TERMIX_PLUGIN_REGISTRY_PRIVATE_HOSTS ?? "")
+    .split(",")
+    .map((value) => value.trim())
+    .filter(Boolean)
+    .map(normalizePrivateHost)
+    .filter((host): host is string => host !== undefined);
+}
+
+/**
+ * The host in the form safeOutboundFetch compares against, or undefined when
+ * the entry carries more than a host, like a scheme, port, path or user.
+ */
+function normalizePrivateHost(entry: string): string | undefined {
+  const candidate = isIP(entry) === 6 ? `[${entry}]` : entry;
+  if (/[/?#@\\]|:\d*$/.test(candidate)) return undefined;
+  try {
+    return new URL(`http://${candidate}`).hostname.replace(/^\[|\]$/g, "");
+  } catch {
+    return undefined;
+  }
+}
+
+/**
+ * With HTTP_PROXY or HTTPS_PROXY set, registry traffic goes through the proxy,
+ * which does its own name lookup. Only the URL itself is checked here: web
+ * pages only, no logins in it, and no private address typed in as a literal.
+ */
+function fetchThroughProxy(
+  url: string,
+  options: RequestInit,
+  privateHosts: readonly string[],
+): Promise<Response> {
+  const parsed = new URL(url);
+  const host = parsed.hostname.replace(/^\[|\]$/g, "");
+  if (
+    !["http:", "https:"].includes(parsed.protocol) ||
+    parsed.username ||
+    parsed.password
+  ) {
+    throw new Error("Invalid outbound URL");
+  }
+  if (isIP(host) && isBlockedAddress(host) && !privateHosts.includes(host)) {
+    throw new Error("Private destinations are not allowed");
+  }
+  return fetchWithProxy(url, options);
+}
+
 /** Follows redirects by hand so each hop still gets the outbound checks. */
 async function fetchFollowing(url: string): Promise<Response> {
+  const privateHosts = getRegistryPrivateHosts();
   let current = url;
   for (let hop = 0; hop <= MAX_REDIRECTS; hop++) {
-    const response = await safeOutboundFetch(current, {
+    const options: RequestInit = {
       method: "GET",
       redirect: "manual",
       headers: { "User-Agent": "Termix" },
-    });
+    };
+    const response = getProxyAgent(current)
+      ? await fetchThroughProxy(current, options, privateHosts)
+      : await safeOutboundFetch(current, options, privateHosts);
     if (response.status >= 300 && response.status < 400) {
       const location = response.headers.get("location");
       if (!location) throw new Error(`redirect without a location: ${current}`);

src/backend/plugins/safe-mode.ts

@@ -0,0 +1,42 @@
+import type { PluginManifest } from "./manifest.js";
+
+/** TERMIX_SAFE_MODE=1 starts only the plugins that draw the app. */
+export function safeModeOn(): boolean {
+  const value = process.env.TERMIX_SAFE_MODE?.trim().toLowerCase();
+  return value === "1" || value === "true";
+}
+
+function isLookPlugin(manifest: PluginManifest): boolean {
+  return (
+    (manifest.contributes?.layouts?.length ?? 0) > 0 ||
+    (manifest.contributes?.themes?.length ?? 0) > 0
+  );
+}
+
+/** Layout and theme plugins, plus the plugins they need to start. */
+export function safeModePluginIds(
+  plugins: { id: string; manifest: PluginManifest }[],
+): Set<string> {
+  const byId = new Map(plugins.map((plugin) => [plugin.id, plugin]));
+  const allowed = new Set<string>();
+  const add = (id: string) => {
+    const plugin = byId.get(id);
+    if (!plugin || allowed.has(id)) return;
+    allowed.add(id);
+    for (const dependency of Object.keys(plugin.manifest.dependencies ?? {})) {
+      add(dependency);
+    }
+  };
+  for (const plugin of plugins) {
+    if (isLookPlugin(plugin.manifest)) add(plugin.id);
+  }
+  return allowed;
+}
+
+/** Whether a plugin may run now. Always true outside safe mode. */
+export function mayRunInSafeMode(
+  pluginId: string,
+  plugins: { id: string; manifest: PluginManifest }[],
+): boolean {
+  return !safeModeOn() || safeModePluginIds(plugins).has(pluginId);
+}