From 7f0a8255835166efa1d17749025a28b417369b4e Mon Sep 17 00:00:00 2001
From: LukeGus <bugattiguy527@gmail.com>
Date: Wed, 30 Sep 2026 23:14:21 -0500
Subject: [PATCH] fix: remote desktop auth method labels and notes for vnc and
 telnet

---
 plugins/remote-desktop/locales/en.json        |  5 ++++-
 plugins/remote-desktop/src/frontend/index.tsx | 10 +++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/plugins/remote-desktop/locales/en.json b/plugins/remote-desktop/locales/en.json
index 74f60567e..306981f08 100644
--- a/plugins/remote-desktop/locales/en.json
+++ b/plugins/remote-desktop/locales/en.json
@@ -86,6 +86,9 @@
       "authentication": "Authentication",
       "storedCredential": "Stored Credential",
       "authMethod": "Auth Method",
+      "authTypeDirect": "Direct",
+      "authTypeCredential": "Credential",
+      "authTypeNone": "None",
       "authTypeNoneDesc": "No credentials are stored. You'll be prompted for a username and password each time you connect; they are not saved.",
       "selectCredential": "Select a credential...",
       "connectionSettings": "Connection Settings",
@@ -218,7 +221,7 @@
     "virtualNetwork": "Virtual Network",
     "unencryptedShell": "Unencrypted shell",
     "remoteDesktopNotes": "Notes",
-    "userDefaultsNote": "Settings left on their default use your Remote Desktop defaults from Settings.",
+    "userDefaultsNote": "Settings you leave unchanged follow your host defaults.",
     "connectionOriginNote": "On the desktop app, RDP, VNC and Telnet use the remote server unless the host is set to This device, which needs a guacd this machine can reach. Set one in the Remote Desktop settings, or per host under guacd Proxy.",
     "docsLink": "View docs",
     "connectionOriginGuacamoleNote": "RDP, VNC and Telnet use the remote server unless you pick \"This device\", which needs a guacd this machine can reach. Set one in the guacd URL setting, or per host under guacd Proxy."
diff --git a/plugins/remote-desktop/src/frontend/index.tsx b/plugins/remote-desktop/src/frontend/index.tsx
index 227fe35c6..47d08a3d6 100644
--- a/plugins/remote-desktop/src/frontend/index.tsx
+++ b/plugins/remote-desktop/src/frontend/index.tsx
@@ -141,7 +141,7 @@ function RemoteDisplay({
   );
 }
 
-function SectionNotes({ protocol }: { protocol: Protocol }) {
+function SectionNotes() {
   const { t } = useTranslation();
   return (
     <SectionCard
@@ -149,7 +149,7 @@ function SectionNotes({ protocol }: { protocol: Protocol }) {
       icon={<Info className="size-3.5" />}
     >
       <div className="flex flex-col gap-2 py-3 text-xs text-muted-foreground">
-        {protocol === "rdp" && <p>{t("hosts.userDefaultsNote")}</p>}
+        <p>{t("hosts.userDefaultsNote")}</p>
         {isElectron() && <p>{t("hosts.connectionOriginNote")}</p>}
       </div>
     </SectionCard>
@@ -219,7 +219,7 @@ function RdpSection(props: HostEditorSectionProps) {
         credentials={props.credentials as never}
       />
       <ToolbarCard form={form} setField={setField} />
-      <SectionNotes protocol="rdp" />
+      <SectionNotes />
     </>
   );
 }
@@ -237,7 +237,7 @@ function VncSection(props: HostEditorSectionProps) {
         credentials={props.credentials as never}
       />
       <ToolbarCard form={form} setField={setField} />
-      <SectionNotes protocol="vnc" />
+      <SectionNotes />
     </>
   );
 }
@@ -253,7 +253,7 @@ function TelnetSection(props: HostEditorSectionProps) {
         credentials={props.credentials as never}
       />
       <ToolbarCard form={form} setField={setField} />
-      <SectionNotes protocol="telnet" />
+      <SectionNotes />
     </>
   );
 }