release-2.7.1 (#1296)

* Add Helm and GitOps deployment setup * fix: build better-sqlite3 from source in Docker (#1267) * fix: preserve runtime SSL settings (#1268) * fix: support forwarding from the memory SSH agent (#1269) * fix: support forwarding from the memory agent * style: format memory agent test * fix: prompt for encrypted SFTP key passphrases (#1270) * fix: prompt for SFTP key passphrases * style: format SSH key utility test * fix: include host context in automation notifications (#1271) * fix: include host context in automation notifications * style: format automation notification changes * fix: reserve sidebar height for host tags (#1272) * fix: keep host action rows stable at large font sizes (#1273) * fix: honor certificate setting during server probe (#1274) * fix: package standard Linux icon sizes (#1275) * fix: avoid duplicate Docker HTTPS listener (#1276) * Fix host status without metrics collection (#1277) * fix: allow eight-digit secure auth codes (#1263) Allow TOTP prompts to accept secure auth codes longer than six digits without blocking valid authentication attempts. Generated with Codebuff 🤖 Co-authored-by: Chetan <chetan.development@gmail.com> Co-authored-by: Codebuff <noreply@codebuff.com> * Harden Helm deployment defaults * Update Helm workflow action * Exclude Helm templates from Prettier * Fix browser RDP file drops (#1279) * Fix Proxmox guest credential usernames (#1280) * Add WSL local terminal option (#1281) * refactor: split the transfer engine into focused modules (#1282) * refactor: extract SFTP promisify helpers into sftp-promisify module * refactor: extract transfer timing and rate stats into transfer-stats module * refactor: extract transfer error classes and recovery checks into transfer-errors module * refactor: extract host/path utility helpers into transfer-host-utils module * refactor: extract SFTP directory tree helpers into transfer-sftp-dir module * refactor: extract segment copy job builder into transfer-segment-copy module * refactor: extract file scan and sample helpers into transfer-scan module * refactor: move throttled progress helper into transfer-stats module * style: format transfer modules * perf: optimize tmux monitor aggregation (#1283) * fix: reserve credential tag row height (#1284) * feat: edit AI provider model settings (#1285) * fix: clarify click-to-expand host setting (#1286) * fix: allow portable imports on remote databases (#1287) * fix: allow HTTPS to share the configured port (#1288) * fix: resolve synced jump hosts on the server (#1289) * fix: make terminal clipboard shortcuts layout independent (#1290) * fix: use compatible fetch dispatcher for Tailscale (#1291) * fix: add OIDC environment recovery override (#1292) * fix: coalesce rapid mobile terminal input (#1293) * fix: coalesce rapid mobile terminal input * fix: support clean xterm patch installs * fix: resolve synced remote desktop host IDs (#1295) * feat: make the SFTP file manager path bar editable (#1294) Co-authored-by: Maxime Bonillo <257463937+dropafterfree@users.noreply.github.com> Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com> * feat: add passkey sign in to the login screen * fix: remove rounded corners from the host list search bar * fix: stop image storage settings text wrapping to one word per line * fix: prevent malformed websocket messages from crashing the server * chore: increment version * fix: remove gaps between host rows in the sidebar list Keep sub-pixel row measurements and stop wiping the size cache on hover. * fix: Failed to connect through jump hosts (#1180) https://github.com/Termix-SSH/Support/issues/1180 * feat: Progress bar for file downloads in the file manager (#1158) https://github.com/Termix-SSH/Support/issues/1158 * feat: Allow setting Silent OIDC Login via ENV var (#1174) https://github.com/Termix-SSH/Support/issues/1174 * feat: `IdentityFile` to limit the number of attempts by agents (#1165) https://github.com/Termix-SSH/Support/issues/1165 * feat: Credentials clone (#1159) https://github.com/Termix-SSH/Support/issues/1159 * chore: update release notes * docs: move helm setup guide to the docs site * fix: type errors in FilteredAgent agent identity handling * fix: remove stale better-sqlite3 prebuilds so the source build is used * fix: actually build better-sqlite3 from source so arm64 docker images work * fix: credential edit pencil in host editor and add clone action to credential list * fix: clear editingHost so the credential pencil actually opens the editor * chore: run format and lint * fix: folder drag and drop upload failing in the file manager * chore: sync Crowdin translations for 2.7.1 --------- Co-authored-by: alex-ctms <alex-ctms@users.noreply.github.com> Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com> Co-authored-by: Chetan Kumar <74929596+ckloop@users.noreply.github.com> Co-authored-by: Chetan <chetan.development@gmail.com> Co-authored-by: Codebuff <noreply@codebuff.com> Co-authored-by: ZacharyZcR <payasonorahc@protonmail.com> Co-authored-by: dropafterfree <maxime.bonillo@gmail.com> Co-authored-by: Maxime Bonillo <257463937+dropafterfree@users.noreply.github.com>
2026-10-28 14:15:24 +00:00 · 2026-08-22 19:47:40 -05:00
1 parent 566b908daf
commit 76fd9eedbf
@@ -9,6 +9,7 @@ const remoteApiMock = vi.hoisted(() => ({
  post: vi.fn(async () => ({ data: { token: "remote-token" } })),
 }));
 const isElectronMock = vi.hoisted(() => vi.fn(() => false));
+const resolveRemoteHostIdMock = vi.hoisted(() => vi.fn());

 vi.mock("@/main-axios", () => ({
  authApi: authApiMock,
@@ -16,6 +17,9 @@ vi.mock("@/main-axios", () => ({
  isElectron: isElectronMock,
  handleApiError: (error: unknown) => error,
 }));
+vi.mock("@/lib/remote-server-api", () => ({
+  resolveRemoteHostId: resolveRemoteHostIdMock,
+}));

 import {
  getGuacdStatus,
@@ -27,6 +31,7 @@ beforeEach(() => {
  authApiMock.post.mockClear();
  remoteApiMock.get.mockClear();
  remoteApiMock.post.mockClear();
+  resolveRemoteHostIdMock.mockReset();
 });

 describe("guacamole API origin", () => {
@@ -60,15 +65,21 @@ describe("guacamole API origin", () => {

  it("sends the connect-host payload unchanged to the remote server", async () => {
    isElectronMock.mockReturnValue(true);
+    resolveRemoteHostIdMock.mockResolvedValue(41);

-    await getGuacamoleTokenFromHost(9, "rdp", {
-      username: "admin",
-      password: "secret",
-      domain: "EXAMPLE",
-    });
+    await getGuacamoleTokenFromHost(
+      9,
+      "rdp",
+      {
+        username: "admin",
+        password: "secret",
+        domain: "EXAMPLE",
+      },
+      "host-sync-id",
+    );

    expect(remoteApiMock.post).toHaveBeenCalledWith(
-      "/guacamole/connect-host/9",
+      "/guacamole/connect-host/41",
      {
        protocol: "rdp",
        promptedUsername: "admin",
@@ -76,6 +87,7 @@ describe("guacamole API origin", () => {
        promptedDomain: "EXAMPLE",
      },
    );
+    expect(resolveRemoteHostIdMock).toHaveBeenCalledWith("host-sync-id");
  });

  it("sends an empty prompted domain for local RDP accounts", async () => {
@@ -94,4 +106,14 @@ describe("guacamole API origin", () => {
      promptedDomain: "",
    });
  });
+
+  it("does not fall back to a colliding local id when sync resolution fails", async () => {
+    isElectronMock.mockReturnValue(true);
+    resolveRemoteHostIdMock.mockResolvedValue(null);
+
+    await expect(
+      getGuacamoleTokenFromHost(9, "rdp", undefined, "missing-sync-id"),
+    ).rejects.toThrow("The synced host does not exist on the remote server");
+    expect(remoteApiMock.post).not.toHaveBeenCalled();
+  });
 });
@@ -0,0 +1,121 @@
+import { describe, expect, it, vi, beforeEach } from "vitest";
+
+const authApiMock = vi.hoisted(() => ({
+  get: vi.fn(async () => ({ data: {} })),
+  post: vi.fn(async () => ({ data: {} })),
+  delete: vi.fn(async () => ({ data: { success: true } })),
+}));
+
+const browserMock = vi.hoisted(() => ({
+  startAuthentication: vi.fn(async () => ({ id: "cred-1" })),
+  startRegistration: vi.fn(async () => ({ id: "cred-1" })),
+  browserSupportsWebAuthn: vi.fn(() => true),
+}));
+
+vi.mock("@/main-axios", () => ({
+  authApi: authApiMock,
+  handleApiError: (error: unknown) => error,
+}));
+
+vi.mock("@simplewebauthn/browser", () => browserMock);
+
+import { isPasskeySupported, loginWithPasskey } from "../../api/webauthn-api";
+
+beforeEach(() => {
+  authApiMock.get.mockClear();
+  authApiMock.post.mockClear();
+  authApiMock.delete.mockClear();
+  browserMock.startAuthentication.mockClear();
+  browserMock.browserSupportsWebAuthn.mockClear();
+});
+
+describe("isPasskeySupported", () => {
+  it("reports what the browser helper returns", () => {
+    browserMock.browserSupportsWebAuthn.mockReturnValueOnce(false);
+    expect(isPasskeySupported()).toBe(false);
+    browserMock.browserSupportsWebAuthn.mockReturnValueOnce(true);
+    expect(isPasskeySupported()).toBe(true);
+  });
+});
+
+describe("loginWithPasskey", () => {
+  it("passes the challenge from options through to verify", async () => {
+    authApiMock.post
+      .mockResolvedValueOnce({
+        data: { options: { challenge: "abc" }, challengeId: "chal-1" },
+      })
+      .mockResolvedValueOnce({ data: { success: true, username: "luke" } });
+
+    const result = await loginWithPasskey("luke", true);
+
+    expect(authApiMock.post).toHaveBeenNthCalledWith(
+      1,
+      "/users/webauthn/authenticate/options",
+      { username: "luke" },
+    );
+    expect(browserMock.startAuthentication).toHaveBeenCalledWith({
+      optionsJSON: { challenge: "abc" },
+    });
+    expect(authApiMock.post).toHaveBeenNthCalledWith(
+      2,
+      "/users/webauthn/authenticate/verify",
+      {
+        challengeId: "chal-1",
+        response: { id: "cred-1" },
+        rememberMe: true,
+      },
+    );
+    expect(result).toEqual({ success: true, username: "luke" });
+  });
+
+  it("omits the username so discoverable passkeys work", async () => {
+    authApiMock.post
+      .mockResolvedValueOnce({
+        data: { options: { challenge: "abc" }, challengeId: "chal-2" },
+      })
+      .mockResolvedValueOnce({ data: { success: true } });
+
+    await loginWithPasskey();
+
+    expect(authApiMock.post).toHaveBeenNthCalledWith(
+      1,
+      "/users/webauthn/authenticate/options",
+      {},
+    );
+    expect(authApiMock.post).toHaveBeenNthCalledWith(
+      2,
+      "/users/webauthn/authenticate/verify",
+      expect.objectContaining({ rememberMe: false }),
+    );
+  });
+
+  it("returns the totp challenge instead of a session", async () => {
+    authApiMock.post
+      .mockResolvedValueOnce({
+        data: { options: { challenge: "abc" }, challengeId: "chal-3" },
+      })
+      .mockResolvedValueOnce({
+        data: { success: true, requires_totp: true, temp_token: "tmp" },
+      });
+
+    const result = await loginWithPasskey("luke");
+
+    expect(result.requires_totp).toBe(true);
+    expect(result.temp_token).toBe("tmp");
+  });
+
+  it("surfaces a cancelled prompt to the caller", async () => {
+    authApiMock.post.mockResolvedValueOnce({
+      data: { options: { challenge: "abc" }, challengeId: "chal-4" },
+    });
+    const cancelled = Object.assign(new Error("cancelled"), {
+      name: "NotAllowedError",
+    });
+    browserMock.startAuthentication.mockRejectedValueOnce(cancelled);
+
+    await expect(loginWithPasskey("luke")).rejects.toMatchObject({
+      name: "NotAllowedError",
+    });
+    expect(authApiMock.post).toHaveBeenCalledTimes(1);
+  });
+});