release-2.9.1 (#1557)

* fix(sso): send the PKCE verifier for GitHub login (#1534)

* fix(remote-desktop): clip cursor overflow without disabling zoom (#1535)

* test(remote-desktop): preserve sessions beyond one hour (#1536)

* fix(hosts): expose controls for overflowing editor tabs (#1537)

* fix(hosts): expose controls for overflowing editor tabs

* test(hosts): mock resize observation in admin panel tests

* fix(status): skip TCP probes while host sessions are active (#1538)

* fix(database): batch session activity persistence (#1539)

* docs(api): describe cookie and API key authentication (#1540)

* fix(snippets): repair missing note column on SQLite upgrades (#1541)

* fix(docker): retain stored SSH credential association (#1543)

* fix(file-manager): render transfer toasts without plugin hooks (#1546)

* feat(hosts): keep compact row actions inline (#1547)

* fix(auth): allow retrying unavailable second-factor interfaces (#1549)

* fix(auth): reject unresolved legacy identity provisioning (#1550)

* fix(desktop): ship the plugin SDK inside Mac App Store builds (#1551)

* fix(tmux): pass full session info to the terminal's session picker (#1552)

The tmux.sessions service reduced detected sessions to bare names, but the
picker reads session.name, so every entry rendered blank and selecting one
sent an empty name, which created a new session instead of attaching.

* fix(ssh): read force keyboard-interactive as a boolean when resolving hosts (#1553)

The column holds the text "true"/"false", and the resolver passed it
through as-is. The string "false" is truthy, so the password provider
treated every saved host as forced keyboard-interactive and left the
password out. Jump hops are built straight from the resolved host, so a
password hop whose server doesn't offer keyboard-interactive failed with
"All configured authentication methods failed".

* fix(database): batch database saves for bulk host writes (#1554)

* fix(database): yield to the event loop between database saves

Each SQLite save serializes and encrypts the whole database into new
buffers, which V8 only releases once the event loop turns. Boot
migrations and bulk host import write plugin settings per host and per
key in an awaited loop, so hundreds of full copies piled up and the
container ran out of memory.

* fix(database): save once per bulk host write instead of once per row

On SQLite every repository write force-saves the whole database. Boot
plugin data migrations, host defaults materialization and the bulk
host routes write one row per host per setting, so they serialized and
encrypted the full database hundreds of times in a row.

DatabaseSaveTrigger.batched wraps a function so force saves made while
it runs collapse into a single save when it finishes. Nested scopes fold
into the outer one, and work that outlives its scope saves normally.

* feat(hosts): add instance-wide predefined tag suggestions (#1548)

* feat(hosts): add shared predefined tag suggestions

* style(hosts): format tag catalog routes

* test(database): advance fake timers past the save yield (#1555)

* fix(i18n): complete Simplified Chinese core and plugin translations (#1542)

* fix(i18n): complete Chinese onboarding and navigation labels

* fix(i18n): translate remaining Chinese core and plugin interfaces

* fix(i18n): translate host editor tab overflow controls

* fix(i18n): use consistent Chinese fleet terminology

* fix(i18n): localize hardcoded controls and plugin views

* fix(i18n): translate built-in homepage widget catalog

* test(homepage): follow translated timezone placeholder

* fix(i18n): translate plugin-provided homepage widgets

* fix(i18n): localize feature settings section titles

* fix: 2.8 oidc accounts unable to sign in after upgrading (#1381)

* fix: plugins losing the saved ssh login when copying a host (#1391)

* fix: fleets, proxmox and automations not getting the host sudo password

* fix: host imports running a defaults pass and metrics restart per host (#1384)

* fix: high cpu from status probes and full database saves on every sample (#1300)

* fix: user data export freezing the server (#1393)

* fix: op:// secret references rejected as ssh keys on credentials (#1394)

* fix: slow file deletes from the trash lookups on every delete (#1390)

* fix: add openapi docs and error handling to host tag routes

* test: compare download stream buffers directly so it stops timing out

* chore: drop em dash from host row comment

* chore: update release notes for 2.9.1

* fix: restore space to add host tags and redesign predefined tags editor

* fix: host key silently accepted when the host is missing from the database (#1397)

* fix: clearer host login failed status label and fix its translations (#1396)

* chore: add host key and status label fixes to release notes

* fix: sso and ldap provider dialogs overflowing the screen and using mismatched toggles

* chore: increment ver

* fix(audit): store plugin entries with no acting user as a null user_id (#1556)

Plugin audit entries written outside a request used the literal "system"
as user_id. That column references users.id, so the insert was refused
(Postgres logs it as an FK violation) and the entry was silently dropped.
Write null instead and keep "system" / plugin:<id> in username.

* chore: add sso/ldap dialog and audit log fixes to release notes

* fix: tunnels and host settings missing from shared hosts on desktop

* fix: remote desktop logins missing from shared hosts on desktop

* fix: simplify host status to online/offline and keep it live without a refresh

* chore: sync Crowdin translations for 2.9.1

---------

Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com>

plugins/file-manager/src/backend/operation-routes.ts

@@ -1,5 +1,6 @@
 import type { Express, Request, Response } from "express";
 import type { PluginContext } from "@termix/plugin-sdk/backend";
+import type { SFTPWrapper } from "ssh2";
 import {
   execChannel,
   execWithSudo,
@@ -24,6 +25,8 @@ type FileOperationRoutesDeps = {
 
 const TRASH_RETENTION_DAYS_KEY = "trashRetentionDays";
 
+const TRASH_PURGE_INTERVAL_MS = 60 * 60 * 1000;
+
 export function registerFileOperationRoutes(
   app: Express,
   { ctx, sshSessions, verifySessionOwnership }: FileOperationRoutesDeps,
@@ -39,6 +42,22 @@ export function registerFileOperationRoutes(
     }
   };
 
+  // Deleting used to purge expired trash first, reading every trash entry
+  // before answering. Do it after the response, at most hourly per session.
+  const lastPurge = new WeakMap<SSHSession, number>();
+  const purgeExpiredTrash = (session: SSHSession, sftp: SFTPWrapper) => {
+    const now = Date.now();
+    if (now - (lastPurge.get(session) ?? 0) < TRASH_PURGE_INTERVAL_MS) return;
+    lastPurge.set(session, now);
+    void getTrashRetentionDays()
+      .then((days) => listTrash(sftp, days))
+      .catch((error) =>
+        ctx.log.warn(
+          `Could not purge expired trash: ${(error as Error).message}`,
+        ),
+      );
+  };
+
   async function ownedSession(
     req: Request,
     res: Response,
@@ -494,9 +513,8 @@ export function registerFileOperationRoutes(
     if (!permanent) {
       try {
         const sftp = await getSessionSftp(sshConn);
-        const retentionDays = await getTrashRetentionDays();
-        await listTrash(sftp, retentionDays);
         const item = await moveToTrash(sftp, itemPath);
+        purgeExpiredTrash(sshConn, sftp);
         ctx.log.info(
           `Item moved to trash: ${sessionId} (${itemPath}, trashId=${item.id})`,
         );

plugins/file-manager/src/backend/trash-service.ts

@@ -70,6 +70,8 @@ async function exists(sftp: SFTPWrapper, target: string) {
 }
 
 async function ensureDirectory(sftp: SFTPWrapper, target: string) {
+  // Usually there already: one round trip instead of one per segment.
+  if (await exists(sftp, target)) return;
   const normalized = target.replace(/\\/g, "/");
   const root = normalized.startsWith("/") ? "/" : "";
   const parts = normalized.split("/").filter(Boolean);
@@ -95,13 +97,32 @@ async function removeTree(sftp: SFTPWrapper, target: string): Promise<void> {
   await rmdir(sftp, target);
 }
 
-async function trashPaths(sftp: SFTPWrapper) {
+type TrashDirs = { root: string; files: string; info: string };
+
+// The trash folders of a channel do not move while it is open, and finding
+// them costs several round trips, which made every delete slow on a remote
+// host (#1390).
+const trashDirsByChannel = new WeakMap<SFTPWrapper, Promise<TrashDirs>>();
+
+function trashPaths(sftp: SFTPWrapper): Promise<TrashDirs> {
+  let dirs = trashDirsByChannel.get(sftp);
+  if (!dirs) {
+    dirs = findTrashPaths(sftp);
+    trashDirsByChannel.set(sftp, dirs);
+    dirs.catch(() => trashDirsByChannel.delete(sftp));
+  }
+  return dirs;
+}
+
+async function findTrashPaths(sftp: SFTPWrapper): Promise<TrashDirs> {
   const home = await call<string>((done) => sftp.realpath(".", done));
   const root = path.posix.join(home.replace(/\\/g, "/"), TRASH_DIR);
   const files = path.posix.join(root, "files");
   const info = path.posix.join(root, "info");
-  await ensureDirectory(sftp, files);
-  await ensureDirectory(sftp, info);
+  await Promise.all([
+    ensureDirectory(sftp, files),
+    ensureDirectory(sftp, info),
+  ]);
   return { root, files, info };
 }
 
@@ -124,7 +145,7 @@ function publicItem(item: StoredTrashItem): TrashItem {
 
 async function readStoredItem(
   sftp: SFTPWrapper,
-  dirs: { root: string; files: string; info: string },
+  dirs: TrashDirs,
   id: string,
 ): Promise<StoredTrashItem> {
   if (!ID_PATTERN.test(id)) throw new Error("Invalid trash item id");

plugins/file-manager/src/frontend/FileManager.tsx

@@ -1416,10 +1416,13 @@ function FileManagerContent({
       const { downloadSSHFileStream } =
         await import("./api/ssh-file-operations-api");
 
-      toast.loading(<DownloadProgressToast fileName={file.name} loaded={0} />, {
-        id: toastId,
-        duration: Infinity,
-      });
+      toast.loading(
+        <DownloadProgressToast t={t} fileName={file.name} loaded={0} />,
+        {
+          id: toastId,
+          duration: Infinity,
+        },
+      );
 
       await downloadSSHFileStream(
         sshSessionId,
@@ -1438,6 +1441,7 @@ function FileManagerContent({
 
           toast.loading(
             <DownloadProgressToast
+              t={t}
               fileName={file.name}
               loaded={loaded}
               total={total}

plugins/file-manager/src/frontend/components/DiffViewer.tsx

@@ -134,7 +134,7 @@ export function DiffViewer({
 
   const handleDownloadFile = async (file: FileItem) => {
     const toastId = toast.loading(
-      <DownloadProgressToast fileName={file.name} loaded={0} />,
+      <DownloadProgressToast t={t} fileName={file.name} loaded={0} />,
       { duration: Infinity },
     );
     try {
@@ -145,6 +145,7 @@ export function DiffViewer({
         ({ loaded, total }) => {
           toast.loading(
             <DownloadProgressToast
+              t={t}
               fileName={file.name}
               loaded={loaded}
               total={total}

plugins/file-manager/src/frontend/components/DownloadProgressToast.tsx

@@ -1,9 +1,10 @@
 import { formatTransferMbPerSec } from "../api/transfer-api";
-import { useTranslation } from "@termix/plugin-sdk/frontend";
+import type { TranslateFn } from "@termix/plugin-sdk/frontend";
 import { ArrowDownToLine } from "lucide-react";
 import { TransferProgressBar } from "./TransferProgressBar";
 
 interface DownloadProgressToastProps {
+  t: TranslateFn;
   fileName: string;
   loaded: number;
   total?: number;
@@ -25,12 +26,12 @@ function formatBytes(bytes: number): string {
 }
 
 export function DownloadProgressToast({
+  t,
   fileName,
   loaded,
   total,
   mbPerSec,
 }: DownloadProgressToastProps) {
-  const { t } = useTranslation();
   const percent =
     total !== undefined && total > 0
       ? Math.min(100, Math.round((loaded / total) * 100))

plugins/file-manager/src/frontend/components/FileViewer.tsx

@@ -350,7 +350,9 @@ export function FileViewer({
       <div className="h-full flex items-center justify-center">
         <div className="text-center">
           <div className="animate-spin rounded-full h-8 w-8 border-b-2 border-blue-500 mx-auto mb-4"></div>
-          <p className="text-sm text-muted-foreground">Loading file...</p>
+          <p className="text-sm text-muted-foreground">
+            {t("fileManager.loadingFile")}
+          </p>
         </div>
       </div>
     );
@@ -446,7 +448,7 @@ export function FileViewer({
                   className="flex items-center gap-2"
                 >
                   <RotateCcw className="w-4 h-4" />
-                  Revert
+                  {t("fileManager.revert")}
                 </Button>
                 <Button
                   variant="default"
@@ -456,7 +458,7 @@ export function FileViewer({
                   className="flex items-center gap-2"
                 >
                   <Save className="w-4 h-4" />
-                  Save
+                  {t("common.save")}
                 </Button>
               </>
             )}
@@ -647,14 +649,12 @@ export function FileViewer({
                   {isTooLarge ? (
                     <div className="bg-destructive/10 border border-destructive/30 rounded p-3 mb-4">
                       <p className="text-sm text-destructive font-medium">
-                        File is too large (&gt; 10MB) and cannot be opened as
-                        text for security reasons.
+                        {t("fileManager.fileTooLarge")}
                       </p>
                     </div>
                   ) : (
                     <p className="text-sm text-muted-foreground mb-4">
-                      Do you want to continue opening this file as text? This
-                      may slow down your browser.
+                      {t("fileManager.confirmOpenAsText")}
                     </p>
                   )}
                 </div>
@@ -669,7 +669,7 @@ export function FileViewer({
                     className="flex items-center gap-2"
                   >
                     <FileText className="w-4 h-4" />
-                    Open as Text
+                    {t("fileManager.openAsText")}
                   </Button>
                 )}
                 <Button
@@ -686,7 +686,7 @@ export function FileViewer({
                   size="sm"
                   onClick={handleCancelOpenAsText}
                 >
-                  Cancel
+                  {t("common.cancel")}
                 </Button>
               </div>
             </div>
@@ -694,7 +694,9 @@ export function FileViewer({
         )}
 
         {fileTypeInfo.type === "image" && !showLargeFileWarning && (
-          <Suspense fallback={<PreviewFallback label="Loading image..." />}>
+          <Suspense
+            fallback={<PreviewFallback label={t("fileManager.loadingImage")} />}
+          >
             <ImagePreview
               content={content}
               fileName={file.name}
@@ -708,7 +710,9 @@ export function FileViewer({
           <div className="h-full flex flex-col">
             {isEditable ? (
               <Suspense
-                fallback={<PreviewFallback label="Loading editor..." />}
+                fallback={
+                  <PreviewFallback label={t("fileManager.loadingEditor")} />
+                }
               >
                 <CodeEditor
                   ref={editorRef}
@@ -857,12 +861,16 @@ export function FileViewer({
                     <div className="p-4">
                       <Suspense
                         fallback={
-                          <PreviewFallback label="Loading preview..." />
+                          <PreviewFallback
+                            label={t("fileManager.loadingPreview")}
+                          />
                         }
                       >
                         <MarkdownRenderer
                           compact
-                          content={editedContent || "Nothing to preview yet..."}
+                          content={
+                            editedContent || t("fileManager.emptyPreview")
+                          }
                         />
                       </Suspense>
                     </div>
@@ -872,7 +880,11 @@ export function FileViewer({
                 <div className="flex-1 overflow-auto thin-scrollbar p-6">
                   <div className="max-w-4xl mx-auto">
                     <Suspense
-                      fallback={<PreviewFallback label="Loading preview..." />}
+                      fallback={
+                        <PreviewFallback
+                          label={t("fileManager.loadingPreview")}
+                        />
+                      }
                     >
                       <MarkdownRenderer content={editedContent} />
                     </Suspense>
@@ -885,7 +897,7 @@ export function FileViewer({
 
         {fileTypeInfo.type === "pdf" && !showLargeFileWarning && (
           <Suspense
-            fallback={<PreviewFallback label="Loading PDF viewer..." />}
+            fallback={<PreviewFallback label={t("fileManager.loadingPdf")} />}
           >
             <PdfPreview
               content={content}
@@ -897,7 +909,7 @@ export function FileViewer({
 
         {fileTypeInfo.type === "audio" && !showLargeFileWarning && (
           <Suspense
-            fallback={<PreviewFallback label="Loading audio player..." />}
+            fallback={<PreviewFallback label={t("fileManager.loadingAudio")} />}
           >
             <AudioPreview
               file={file}
@@ -940,7 +952,7 @@ export function FileViewer({
           <span>{file.path}</span>
           {hasChanges && (
             <span className="text-orange-600 font-medium">
-              ● Unsaved changes
+              ● {t("common.unsavedChanges")}
             </span>
           )}
         </div>

plugins/file-manager/src/frontend/components/FileWindow.tsx

@@ -483,7 +483,7 @@ export function FileWindow({
 
   const handleDownload = async () => {
     const toastId = toast.loading(
-      <DownloadProgressToast fileName={file.name} loaded={0} />,
+      <DownloadProgressToast t={t} fileName={file.name} loaded={0} />,
       { duration: Infinity },
     );
     try {
@@ -495,6 +495,7 @@ export function FileWindow({
         ({ loaded, total }) => {
           toast.loading(
             <DownloadProgressToast
+              t={t}
               fileName={file.name}
               loaded={loaded}
               total={total}

plugins/file-manager/src/frontend/components/ImagePreview.tsx

@@ -103,7 +103,9 @@ export function ImagePreview({
         <div className="absolute inset-0 flex items-center justify-center bg-background/80">
           <div className="text-center">
             <div className="animate-spin rounded-full h-8 w-8 border-b-2 border-blue-500 mx-auto mb-2"></div>
-            <p className="text-sm text-muted-foreground">Loading image...</p>
+            <p className="text-sm text-muted-foreground">
+              {t("fileManager.loadingImage")}
+            </p>
           </div>
         </div>
       )}

plugins/file-manager/src/frontend/components/LocalTransferProgressToast.tsx

@@ -1,5 +1,5 @@
 import { Button } from "@termix/plugin-sdk/ui";
-import { useTranslation } from "@termix/plugin-sdk/frontend";
+import type { TranslateFn } from "@termix/plugin-sdk/frontend";
 import { formatFileSize } from "../file-manager-utils.ts";
 
 export interface LocalTransferBatchStatus {
@@ -16,15 +16,16 @@ export interface LocalTransferBatchStatus {
 }
 
 interface LocalTransferProgressToastProps {
+  t: TranslateFn;
   status: LocalTransferBatchStatus;
   onCancel?: () => void;
 }
 
 export function LocalTransferProgressToast({
+  t,
   status,
   onCancel,
 }: LocalTransferProgressToastProps) {
-  const { t } = useTranslation();
   const percent =
     status.totalBytes > 0
       ? Math.min(100, Math.round((status.bytesDone / status.totalBytes) * 100))

plugins/file-manager/src/frontend/components/TransferProgressToast.tsx

@@ -4,7 +4,7 @@ import {
   getTransferProgressPercent,
   type TransferProgressResponse,
 } from "../api/transfer-api";
-import { useTranslation } from "@termix/plugin-sdk/frontend";
+import type { TranslateFn } from "@termix/plugin-sdk/frontend";
 import {
   Archive,
   ArchiveRestore,
@@ -16,6 +16,7 @@ import {
 import { TransferProgressBar } from "./TransferProgressBar";
 
 interface TransferProgressToastProps {
+  t: TranslateFn;
   status: TransferProgressResponse;
   liveMbPerSec?: number;
   stalled?: boolean;
@@ -25,6 +26,7 @@ interface TransferProgressToastProps {
 }
 
 export function TransferProgressToast({
+  t,
   status,
   liveMbPerSec,
   stalled = false,
@@ -32,7 +34,6 @@ export function TransferProgressToast({
   onCancel,
   cancelling = false,
 }: TransferProgressToastProps) {
-  const { t } = useTranslation();
   const percent = getTransferProgressPercent(status);
 
   let title = t("transfer.progressTransferring");

plugins/file-manager/src/frontend/hooks/useLocalTransfers.ts

@@ -193,6 +193,7 @@ export function useLocalTransfers({
       const render = () => {
         toast.loading(
           createElement(LocalTransferProgressToast, {
+            t,
             status: { ...status, cancelling },
             onCancel: () => {
               cancelled = true;

plugins/file-manager/src/frontend/transferProgressMonitor.tsx

@@ -38,6 +38,7 @@ function formatFileSize(bytes?: number): string {
 }
 
 function renderTransferProgressToast(
+  t: TFunction,
   toastId: string | number,
   status: TransferProgressResponse,
   liveMbPerSec?: number,
@@ -47,6 +48,7 @@ function renderTransferProgressToast(
 ): void {
   toast.loading(
     <TransferProgressToast
+      t={t}
       status={status}
       liveMbPerSec={liveMbPerSec}
       stalled={stalled}
@@ -265,6 +267,7 @@ export function beginTransferProgressMonitoring(
 
   const progressToast = toast.loading(
     <TransferProgressToast
+      t={t}
       status={initialStatus}
       formatSize={formatFileSize}
     />,
@@ -279,6 +282,7 @@ export function beginTransferProgressMonitoring(
     if (cancelling) return;
     cancelling = true;
     renderTransferProgressToast(
+      t,
       progressToast,
       { ...initialStatus, transferId },
       undefined,
@@ -294,6 +298,7 @@ export function beginTransferProgressMonitoring(
       options.onProgress?.(status);
       const { rate, stalled } = progressTracker.update(status);
       renderTransferProgressToast(
+        t,
         progressToast,
         status,
         rate,
@@ -333,6 +338,7 @@ export function beginTransferProgressMonitoring(
     });
 
   renderTransferProgressToast(
+    t,
     progressToast,
     initialStatus,
     undefined,