fix: prompt shared RDP users for credentials (#1345)

src/ui/features/guacamole/GuacamoleApp.tsx

@@ -46,6 +46,7 @@ import { ShareSessionModal } from "@/features/session-sharing/ShareSessionModal.
 import type { SSHHost } from "@/types";
 import { useConnectionDefaults } from "@/contexts/ConnectionDefaultsContext";
 import { resolveConnectionDefaults } from "@/lib/connection-defaults";
+import { needsRdpCredentialPrompt } from "@/features/guacamole/rdp-credential-prompt";
 
 interface GuacamoleAppProps {
   hostId?: string;
@@ -162,6 +163,7 @@ interface GuacamoleAppInnerProps {
     | "domain"
     | "guacamoleConfig"
     | "rdpAuthType"
+    | "authOverrides"
     | "syncId"
     | "ip"
     | "rdpPort"
@@ -230,8 +232,11 @@ const GuacamoleAppInner = React.forwardRef<
   const resolvedProtocolForConnect = (protocol ??
     hostConfig.connectionType ??
     "rdp") as "rdp" | "vnc" | "telnet";
-  const needsCredentialPrompt =
-    resolvedProtocolForConnect === "rdp" && hostConfig.rdpAuthType === "none";
+  const needsCredentialPrompt = needsRdpCredentialPrompt({
+    protocol: resolvedProtocolForConnect,
+    rdpAuthType: hostConfig.rdpAuthType,
+    authOverrides: hostConfig.authOverrides,
+  });
 
   const [promptedCredentials, setPromptedCredentials] = useState<{
     username: string;

src/ui/features/guacamole/rdp-credential-prompt.ts

@@ -0,0 +1,17 @@
+import type { HostAuthOverrides } from "@/types/auth-protocols";
+
+export function needsRdpCredentialPrompt({
+  protocol,
+  rdpAuthType,
+  authOverrides,
+}: {
+  protocol: "rdp" | "vnc" | "telnet";
+  rdpAuthType?: string;
+  authOverrides?: HostAuthOverrides;
+}): boolean {
+  return (
+    protocol === "rdp" &&
+    rdpAuthType === "none" &&
+    !authOverrides?.rdp?.credentialId
+  );
+}

src/ui/tests/features/guacamole/rdp-credential-prompt.test.ts

@@ -0,0 +1,28 @@
+import { describe, expect, it } from "vitest";
+import { needsRdpCredentialPrompt } from "@/features/guacamole/rdp-credential-prompt";
+
+describe("needsRdpCredentialPrompt", () => {
+  it("prompts recipients when RDP has no saved authentication", () => {
+    expect(
+      needsRdpCredentialPrompt({ protocol: "rdp", rdpAuthType: "none" }),
+    ).toBe(true);
+  });
+
+  it("does not prompt when the recipient has a personal override", () => {
+    expect(
+      needsRdpCredentialPrompt({
+        protocol: "rdp",
+        rdpAuthType: "none",
+        authOverrides: {
+          rdp: { credentialId: 7, required: false, ownerAuthShared: true },
+        },
+      }),
+    ).toBe(false);
+  });
+
+  it("does not prompt for other protocols", () => {
+    expect(
+      needsRdpCredentialPrompt({ protocol: "vnc", rdpAuthType: "none" }),
+    ).toBe(false);
+  });
+});