fix: host status shows online when the port answers and only warns on a failed login

src/backend/plugins/ctx-ssh-auth.ts

@@ -33,6 +33,7 @@ import {
 } from "../hosts/connect/auth-provider-registry.js";
 import { classifyKeyboardInteractive } from "../hosts/connect/keyboard-interactive.js";
 import { ensureCoreSshAuthProviders } from "../hosts/connect/core-providers.js";
+import { isHostKeyVerificationError } from "../hosts/status/host-status.js";
 import {
   getLoginMethod,
   registerLoginMethod,
@@ -95,6 +96,9 @@ function describeHost(host: number | PluginSshHost): string {
   return typeof host === "number" ? `host ${host}` : `host ${host.id}`;
 }
 
+const LOGIN_FAILED =
+  /all configured authentication methods failed|permission denied|authentication failed/i;
+
 export function createPluginSsh({ manifest, bag, audit }: Deps): PluginSsh {
   const pluginId = manifest.id;
   const declared = manifest.capabilities;
@@ -164,14 +168,24 @@ export function createPluginSsh({ manifest, bag, audit }: Deps): PluginSsh {
     return { ...(host as unknown as SshConnectHost), userId };
   };
 
-  /** A login to a saved host core resolved counts toward its status dot. */
-  const reportLogin = (host: number | PluginSshHost) => {
+  /**
+   * A login to a saved host core resolved feeds its status dot. Only a clear
+   * auth or host key failure counts: a timeout says nothing about the login.
+   */
+  const reportLogin = (host: number | PluginSshHost, error?: unknown) => {
     const hostId =
       typeof host === "number" ? host : resolvedHosts.get(host)?.host.id;
     if (!Number.isInteger(hostId) || hostId <= 0) return;
+    let outcome: { ok: boolean; hostKeyChanged?: boolean } = { ok: true };
+    if (error !== undefined) {
+      const message = error instanceof Error ? error.message : String(error);
+      const hostKeyChanged = isHostKeyVerificationError(error);
+      if (!hostKeyChanged && !LOGIN_FAILED.test(message)) return;
+      outcome = { ok: false, hostKeyChanged };
+    }
     void import("../hosts/status/host-status-service.js")
       .then(({ hostStatusService }) =>
-        hostStatusService.reportLogin(hostId, { ok: true }),
+        hostStatusService.reportLogin(hostId, outcome),
       )
       .catch(() => {});
   };
@@ -231,6 +245,7 @@ export function createPluginSsh({ manifest, bag, audit }: Deps): PluginSsh {
         success: false,
         errorMessage: error instanceof Error ? error.message : String(error),
       });
+      reportLogin(host, error);
       throw error;
     }
   };