mirror of
https://github.com/Termix-SSH/Termix.git
synced 2026-10-29 22:55:24 +00:00
release-2.9.0 (#1532)
* fix(macos): skip single-instance lock in Mac App Store builds (#1454)
fix(macos): skip single-instance lock in Mac App Store builds
* Fix/backend optional sharp (#1455)
Fix/backend optional sharp
* feat: issue #1218 (#1218)
https://github.com/Termix-SSH/Support/issues/1218
* feat: Add option to use saved global custom theme under Connection Defaults (#1209)
https://github.com/Termix-SSH/Support/issues/1209
* feat: Add Fleet Sharing functionality to the UI (#1228)
https://github.com/Termix-SSH/Support/issues/1228
* feat: Add a list view to the Docker management page (#1237)
https://github.com/Termix-SSH/Support/issues/1237
* feat: issue #1264 (#1264)
https://github.com/Termix-SSH/Support/issues/1264
* feat: 2FA With FortiToken (#1288)
https://github.com/Termix-SSH/Support/issues/1288
* feat: Allow to disable showing paths to folders (#1274)
https://github.com/Termix-SSH/Support/issues/1274
* feat: Sync Network Graph between Desktop and Remote Server (#1245)
https://github.com/Termix-SSH/Support/issues/1245
* feat: Version Number on offline servers (#1291)
https://github.com/Termix-SSH/Support/issues/1291
* feat: Support OrbStack Docker socket path on macOS / Fix "Docker is not installed" on mac... (#1302)
https://github.com/Termix-SSH/Support/issues/1302
* feat: Sidebar host click should focus existing tab instead of opening a new connection (#1289)
https://github.com/Termix-SSH/Support/issues/1289
* fix: Search in side bar shows overlapping hosts when grouped by tags (#1303)
https://github.com/Termix-SSH/Support/issues/1303
* fix: I can't send a file on its own. (#1304)
https://github.com/Termix-SSH/Support/issues/1304
* fix: sudo password not autofilling (#1248)
https://github.com/Termix-SSH/Support/issues/1248
* fix: node-MainThread (#1300)
https://github.com/Termix-SSH/Support/issues/1300
* fix: Tunnel authentication with shared credentials (#1295)
https://github.com/Termix-SSH/Support/issues/1295
* fix: host key updates not syncing, metrics 404 race on first connect
Host key writes never bumped updatedAt so sync never picked them up.
Also retry the first metrics fetch briefly instead of failing right away.
* chore: increment ver
* feat: add category and icon fields to plugin manifest schema
* ci(deps): bump the github-actions group with 2 updates (#1458)
Bumps the github-actions group with 2 updates: [crowdin/github-action](https://github.com/crowdin/github-action) and [actions/github-script](https://github.com/actions/github-script).
Updates `crowdin/github-action` from 2 to 3
- [Release notes](https://github.com/crowdin/github-action/releases)
- [Commits](https://github.com/crowdin/github-action/compare/v2...v3)
Updates `actions/github-script` from 7 to 9
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](https://github.com/actions/github-script/compare/v7...v9)
---
updated-dependencies:
- dependency-name: crowdin/github-action
dependency-version: '3'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions
- dependency-name: actions/github-script
dependency-version: '9'
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps-dev): bump the dev-patch-updates group with 13 updates (#1459)
Bumps the dev-patch-updates group with 13 updates:
| Package | From | To |
| --- | --- | --- |
| [@codemirror/commands](https://github.com/codemirror/commands) | `6.11.0` | `6.11.1` |
| [@codemirror/search](https://github.com/codemirror/search) | `6.7.1` | `6.7.2` |
| [@codemirror/view](https://github.com/codemirror/view) | `6.43.9` | `6.43.12` |
| [@testing-library/dom](https://github.com/testing-library/dom-testing-library) | `10.4.1` | `10.4.2` |
| [@testing-library/react](https://github.com/testing-library/react-testing-library) | `16.3.2` | `16.3.3` |
| [@testing-library/user-event](https://github.com/testing-library/user-event) | `14.6.5` | `14.6.7` |
| [@types/ssh2](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ssh2) | `1.15.5` | `1.15.6` |
| [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react) | `6.1.0` | `6.1.1` |
| [cytoscape](https://github.com/cytoscape/cytoscape.js) | `3.34.1` | `3.34.3` |
| [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) | `0.5.4` | `0.5.7` |
| [i18next](https://github.com/i18next/i18next) | `26.4.0` | `26.4.2` |
| [prettier](https://github.com/prettier/prettier) | `3.9.6` | `3.9.8` |
| [react-i18next](https://github.com/i18next/react-i18next) | `17.0.12` | `17.0.14` |
Updates `@codemirror/commands` from 6.11.0 to 6.11.1
- [Changelog](https://github.com/codemirror/commands/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/commands/commits)
Updates `@codemirror/search` from 6.7.1 to 6.7.2
- [Changelog](https://github.com/codemirror/search/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/search/commits)
Updates `@codemirror/view` from 6.43.9 to 6.43.12
- [Changelog](https://github.com/codemirror/view/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codemirror/view/commits)
Updates `@testing-library/dom` from 10.4.1 to 10.4.2
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v10.4.1...v10.4.2)
Updates `@testing-library/react` from 16.3.2 to 16.3.3
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/react-testing-library/compare/v16.3.2...v16.3.3)
Updates `@testing-library/user-event` from 14.6.5 to 14.6.7
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v14.6.5...v14.6.7)
Updates `@types/ssh2` from 1.15.5 to 1.15.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ssh2)
Updates `@vitejs/plugin-react` from 6.1.0 to 6.1.1
- [Release notes](https://github.com/vitejs/vite-plugin-react/releases)
- [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite-plugin-react/commits/plugin-react@6.1.1/packages/plugin-react)
Updates `cytoscape` from 3.34.1 to 3.34.3
- [Release notes](https://github.com/cytoscape/cytoscape.js/releases)
- [Commits](https://github.com/cytoscape/cytoscape.js/compare/v3.34.1...v3.34.3)
Updates `eslint-plugin-react-refresh` from 0.5.4 to 0.5.7
- [Release notes](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/releases)
- [Changelog](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/compare/v0.5.4...v0.5.7)
Updates `i18next` from 26.4.0 to 26.4.2
- [Release notes](https://github.com/i18next/i18next/releases)
- [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md)
- [Commits](https://github.com/i18next/i18next/compare/v26.4.0...v26.4.2)
Updates `prettier` from 3.9.6 to 3.9.8
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.9.6...3.9.8)
Updates `react-i18next` from 17.0.12 to 17.0.14
- [Changelog](https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md)
- [Commits](https://github.com/i18next/react-i18next/compare/v17.0.12...v17.0.14)
---
updated-dependencies:
- dependency-name: "@codemirror/commands"
dependency-version: 6.11.1
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@codemirror/search"
dependency-version: 6.7.2
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@codemirror/view"
dependency-version: 6.43.12
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@testing-library/dom"
dependency-version: 10.4.2
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@testing-library/react"
dependency-version: 16.3.3
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@testing-library/user-event"
dependency-version: 14.6.7
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@types/ssh2"
dependency-version: 1.15.6
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: "@vitejs/plugin-react"
dependency-version: 6.1.1
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: cytoscape
dependency-version: 3.34.3
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: eslint-plugin-react-refresh
dependency-version: 0.5.7
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: i18next
dependency-version: 26.4.2
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: prettier
dependency-version: 3.9.8
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
- dependency-name: react-i18next
dependency-version: 17.0.14
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: dev-patch-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps): bump the prod-patch-updates group with 6 updates (#1461)
Bumps the prod-patch-updates group with 6 updates:
| Package | From | To |
| --- | --- | --- |
| [@tanstack/react-virtual](https://github.com/TanStack/virtual/tree/HEAD/packages/react-virtual) | `3.14.10` | `3.14.13` |
| [compression](https://github.com/expressjs/compression) | `1.8.1` | `1.8.2` |
| [jose](https://github.com/panva/jose) | `6.2.9` | `6.2.12` |
| [jszip](https://github.com/Stuk/jszip) | `3.10.1` | `3.10.2` |
| [socks](https://github.com/JoshGlazebrook/socks) | `2.8.9` | `2.8.10` |
| [undici](https://github.com/nodejs/undici) | `8.10.0` | `8.10.2` |
Updates `@tanstack/react-virtual` from 3.14.10 to 3.14.13
- [Release notes](https://github.com/TanStack/virtual/releases)
- [Changelog](https://github.com/TanStack/virtual/blob/main/packages/react-virtual/CHANGELOG.md)
- [Commits](https://github.com/TanStack/virtual/commits/@tanstack/react-virtual@3.14.13/packages/react-virtual)
Updates `compression` from 1.8.1 to 1.8.2
- [Release notes](https://github.com/expressjs/compression/releases)
- [Changelog](https://github.com/expressjs/compression/blob/master/HISTORY.md)
- [Commits](https://github.com/expressjs/compression/compare/v1.8.1...v1.8.2)
Updates `jose` from 6.2.9 to 6.2.12
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/main/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v6.2.9...v6.2.12)
Updates `jszip` from 3.10.1 to 3.10.2
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.10.1...v3.10.2)
Updates `socks` from 2.8.9 to 2.8.10
- [Release notes](https://github.com/JoshGlazebrook/socks/releases)
- [Commits](https://github.com/JoshGlazebrook/socks/compare/2.8.9...2.8.10)
Updates `undici` from 8.10.0 to 8.10.2
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](https://github.com/nodejs/undici/compare/v8.10.0...v8.10.2)
---
updated-dependencies:
- dependency-name: "@tanstack/react-virtual"
dependency-version: 3.14.13
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
- dependency-name: compression
dependency-version: 1.8.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
- dependency-name: jose
dependency-version: 6.2.12
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
- dependency-name: jszip
dependency-version: 3.10.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
- dependency-name: socks
dependency-version: 2.8.10
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
- dependency-name: undici
dependency-version: 8.10.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: prod-patch-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add plugin worker protocol, bootstrap and plugin_storage table
Worker-side ctx proxy plus the message envelope it talks over, and the
per-plugin key/value table behind ctx.storage with migrations for all
three dialects. Rows cascade with the plugin so uninstalling leaves
nothing behind.
* feat: add allowlisted host view for plugins
An allowlist rather than a list of fields to strip. A blocklist rots:
the moment a new secret-bearing column lands on SSHHost it starts
leaking silently. With an allowlist a new field stays invisible to
plugins until someone adds it here on purpose.
* feat: add plugin loader with manifest validation and crash restart
Validates an unpacked plugin, spawns a worker_threads worker and manages
activate/deactivate/crash-restart with backoff, disabling after three
tries.
The crash counter clears only after a plugin stays up past a stability
window, not on activation. Clearing it on activation let a plugin that
activates cleanly and then dies restart forever, because every attempt
looked like the first.
loader.ts documents what the worker boundary does and does not buy you.
Node's permission model is process-wide, not per-worker, so it cannot be
enabled for plugin workers alone and is not claimed here.
* feat: route internal events through a shared plugin event bus
Formalises three ad-hoc publish paths that already existed:
automation-events.ts, metrics/automation-bridge.ts and the
hostSessionStatus singleton, now the host.session.status topic.
Both invariants the old code relied on are preserved. Publishing stays
fire-and-forget, so a failing subscriber cannot disturb a metrics poll or
a host delete. The automations engine subscribes to the bus at scheduler
start instead of being imported ad hoc, which keeps the edge
one-directional: automations may import repositories, hosts modules must
not import automations.
* feat: add plugin ctx broker with permission gate and audit
Every ctx call a plugin makes is checked against its granted
capabilities, performed by the main thread, then audited. A capability
must be both declared in the manifest and granted in the database, so
widening a plugin's reach always needs a new manifest the user can see,
never just a database row.
Audit attribution is set by the broker, not the plugin. The plugin
supplies only the details, so it cannot forge the actor.
fix: stop plugin workers seeing plaintext credentials in error messages
A failing ctx.ssh.connect handed the worker the raw error from deep in
the SSH stack, which embeds the connect config. The worker received, in
full:
Authentication failed for root using password <SECRET>
where <SECRET> was the host's real plaintext password. Any plugin with
ssh.exec could read it by catching the error, defeating the whole point
of the handle-based ssh API.
Errors crossing the boundary are now sanitised. Only PluginFacingError
and PluginPermissionError, both authored here, reach a plugin verbatim;
anything else becomes a generic message and the real one goes to the
log. This uses a marker class rather than matching on message text,
because matching would start leaking again the moment an upstream error
happened to contain a familiar phrase.
Covered by credential-isolation.test.ts, which plants a sentinel in
every secret-bearing field and asserts it appears in no message the
worker ever receives.
* feat: dispatch plugin HTTP routes and wire the runtime into startup
ctx.http.route now registers a real router on the /plugin-api/:pluginId
dispatcher, replacing its stub 404. A plugin never touches the Express
req/res: it gets a plain summary and returns a plain object, so sockets
and session cookies stay on this side of the boundary. Authorization and
cookie headers are not forwarded.
Plugins load last in the start-up sequence, after the server is fully
wired, and are terminated before the database on shutdown so none can
outlive it. A plugin that fails to load cannot stop the backend.
fix: correct the nginx plugin-api location regex
The pattern was ^/plugin-api/(/.*)?$, which needs a double slash and so
never matched /plugin-api/<id>/<route>. Every other block in the file
uses ^/prefix(/.*)?$. Left alone, plugin routes would work in dev and
404 only behind Docker.
* fix: update stale SFTP transfer test for single file destination paths
The test still asserted transferToHost was called with the destination
directory "/srv". Commit 7727fa09 (#1304) deliberately changed a single
file transfer to send the full destination path including the filename,
so the correct expectation is "/srv/remote-1.txt". The code was right
and the test was left behind.
* feat: ship the ssh terminal as a first-party in-process plugin
Adds a hardcoded process:transport-owner tier so the terminal can own its
WebSocket server and ssh2 clients, which cannot cross the worker boundary.
* feat: ship docker as a first-party in-process plugin
Moves docker backend and frontend into plugins/docker/, alongside
ssh-terminal. Adds a host editor tab seam, a dashboard card registry,
and a build step to compile plugin backends into dist.
* feat: ship host metrics as a first-party in-process plugin
* fix: harden plugin auth and add per-request identity for ctx calls
Require auth on /plugin-api, gate plugin enable/grant/revoke routes
behind admin.plugins.manage, and thread the calling user through
worker ctx.hosts/ctx.ssh calls instead of always using the install
owner. Also adds the plugin permissions grant/revoke UI.
* feat: ship the AI assistant as a first-party in-process plugin
Moves src/backend/ai and its routes into plugins/ai, mounted through a
small /ai dispatcher instead of its own port. Moves the ai-enabled and
ai-private-endpoints settings routes out of user-settings-routes.ts
into the plugin too, so it has no leftover core dependents.
* fix: remove compiled plugin JS left behind in plugins/ after build
copy-bundled-plugins.cjs compiled and rewrote plugin backend TS in
place, copied it to dist/plugins, but never deleted the .js it had
just emitted next to the .ts sources. Those files shadowed the real
source for vitest/tsx and had import paths rewritten for the dist
layout, so tests failed with "Cannot find module" once a local build
had run. Affects docker, host-metrics and ai, not just this one.
* feat: add a permission-gated backend service registry for plugins
* feat: add a permission-gated UI action registry and action slots for plugins
Moves the terminal toolbar's hardwired AI button into a slot the ssh-terminal
plugin offers and the ai plugin fills, gated on ai.services.use.
* feat: add cross-plugin secret references gated by the provider's RBAC permission
* feat: move proxmox discovery/import/sync into a first-party plugin
* feat: move remote desktop (RDP/VNC/Telnet) into a first-party plugin
Relocates guacamole backend/frontend source and tests into
plugins/remote-desktop, following the ssh-terminal/docker pattern.
* feat: wire remote-desktop plugin into core and rename i18n keys
Repoints core consumers (dispatcher, collab, session-sharing, tab
utils) at the plugin, adds isTabTypeAvailable gating for rdp/vnc/
telnet, widens hostCapability to accept an array, and renames the
guacamole i18n namespace to remoteDesktop.
* feat: move fleets into a first-party plugin
* feat: move automations into a first-party plugin
* feat: remove legacy alert rules, superseded by automations
Alert rules already auto-migrate into automations on boot and the old
engine stands down after. Deletes the rule/firing tables, routes, UI,
and AI tools; keeps notification channels since automations still use
them. Also fixes automations' notify step, which still called the
deleted repository.
* feat: move network topology into a first-party plugin
* feat: move tailscale device discovery and settings into a plugin
Adds plugins/tailscale/ with a devices sidebar tab, admin settings
section, and re-auth dialog. Host Metrics tailscale manager card and
SSH re-auth banner parsing stay in core.
* feat: move workspaces into a first-party plugin
* feat: move web endpoint into a first-party plugin
* feat: collapse plugin runtime to one tier behind a plugin SDK
* feat: make each plugin an npm workspace built by a termix-plugin CLI
* feat: give plugins their own tables, migrations and sync entities
* feat: serve plugin http and websockets from one mount instead of ports
* feat: namespace plugin permissions and keep them valid when a plugin is off
* feat: give plugins their own settings and one settings screen
* feat: load plugin frontends at runtime and remove plugin ids from the shell
* fix: mock the ai status fetch in its activate test
* feat: add auth extension points and one ssh connect pipeline
* feat: rebuild workspaces as the reference plugin
* fix: gate second factors after SSO/LDAP behind an admin setting
* feat: convert network-topology to a full plugin (B1)
* feat: move snippets backend and tables into a plugin (B2)
* feat: point core frontend snippets pickers at the plugin (B2)
* feat: add the snippets plugin (B2)
* feat: wire ai, automations, fleets and ssh-terminal to snippets (B2)
* feat: finish the tailscale plugin, including SSH auth (B3)
* feat: finish the fleets plugin, add ctx.hosts and host-commands SDK (B4)
* chore: update proxmox and host-metrics locale files for B5
* chore: regenerate drizzle migration journals for B5
* feat: add ctx.hosts create/update to the SDK, host-metrics drops proxmox
* feat: move proxmox node stats and collectors into the proxmox plugin
* feat: drop proxmox host columns, use plugin settings instead
* feat: finish the fleets plugin, add ctx.hosts and host-commands SDK (B4)
* feat: convert file manager into a plugin
* feat: convert ssh tunnels into a plugin
* feat: finish the web-endpoint plugin, add ctx.desktop (B8)
* feat: move the terminal fully into the ssh-terminal plugin (B9)
* feat: convert tmux monitoring into a plugin (B10)
* feat: convert serial console into the serial plugin
* feat: move session sharing and collab rooms into a plugin (B12)
* feat: turn session recording into a plugin (B13)
* feat: finish the remote-desktop plugin (B14)
* feat: finish the host-metrics plugin, move host status into core (B16)
* feat: finish the docker plugin (B15)
* feat: finish the automations plugin (B17)
* feat: finish the ai plugin (B18)
* feat: finish the homepage plugin, move service links and canvas out of core (B19)
* feat: convert wake-on-lan into a plugin (B20)
* feat: convert secret-sources into a plugin (B20)
* feat: move totp and passkeys into plugins (C1)
* feat: move sso and ldap logins into plugins (C2)
* feat: move opkssh and warpgate into plugins (C3)
* feat: move step-ca into a plugin (C4)
* feat: move vault ssh signing into a plugin (C5)
* feat: move termix identity into a plugin (C6)
* feat: move acme certificate automation into a plugin (C7)
* fix: finish 2.9.0 plugin moves and get every check green
* chore: lock the plugin boundary and remove 2.9.0 leftovers
* fix: harden the plugin runtime after the 2.9.0 security review
* feat: add plugin packing, signing, pinned trust and tmxplug bundling
* test: prove 2.8 to 2.9.0 upgrade is lossless and fix what it caught
* fix: give bundled plugin backends a real require for CJS deps
* feat: improve UI loading time and jitter
* feat: show credential sharing inline in the sidebar like host sharing
* feat: tailscale add host and copy ip, fix outbound fetch hang and plugin ESM warning
* feat: unify alerts into one plugin, channels, rules and inbox
* feat: rebuild desktop sync as linked server accounts, fix packaged plugin bundles and UI scaling
* fix: set blacksmith builder cache-key to stop broken gha cache fallback
* fix: link plugin-sdk workspace before npm ci in docker deps stage
* fix: link every plugin workspace before npm ci in docker deps stage
* fix(host-metrics): exclude image and firmware filesystems (#1469)
* fix(host-metrics): exclude image and firmware filesystems
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(hosts): normalize imported jump host references (#1470)
* fix(hosts): normalize imported jump host references
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(ci): build plugin SDK and repair MySQL settings migration (#1471)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(file-manager): keep inline rename consistent (#1476)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(file-manager): keep inline rename consistent
* fix(dashboard): reuse translated host status labels (#1475)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(dashboard): reuse translated host status labels
* docs(api): clarify local and remote version fields (#1474)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* docs(api): clarify local and remote version fields
* fix(file-manager): preserve selected backgrounds on hover (#1473)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(file-manager): preserve selection feedback on hover
* test(ui): await dialog focus cleanup before teardown
* fix(file-manager): restore Ctrl/Cmd+F file search (#1472)
* fix(ci): build plugin SDK before dependent checks
* fix(mysql): keep plugin settings scope indexes within limits
* test(mysql): refresh reviewed plugin upgrade SQL
* fix(file-manager): focus file search with Ctrl or Cmd F
* fix: keep rounded-full circular in production builds
* fix(file-manager): cancel uploads and stop remote writes (#1477)
* fix(file-manager): cancel uploads and stop remote writes
* test(css): exercise the configured PostCSS plugin chain
* fix(file-manager): apply compact density to directory tree (#1478)
* fix(file-manager): apply compact density to directory tree
* test(css): exercise the configured PostCSS plugin chain
* fix(file-manager): preserve font sizes in compact mode (#1480)
* fix(file-manager): preserve font sizes in compact mode
* test(css): exercise the configured PostCSS plugin chain
* fix(file-manager): prioritize file names in narrow lists (#1483)
* fix(file-manager): prioritize file names in narrow lists
* test(css): exercise the configured PostCSS plugin chain
* test(identity): preserve full Ed25519 public keys in fixtures
* test(remote-desktop): always mutate ciphertext in tamper test
* fix(remote-desktop): probe the saved host guacd endpoint (#1481)
* fix(remote-desktop): probe the saved host guacd endpoint
* test(css): exercise the configured PostCSS plugin chain
* test(identity): preserve full Ed25519 public keys in fixtures
* fix(homepage): check allowlisted private service reachability (#1479)
* fix(homepage): check allowlisted private service reachability
* test(css): exercise the configured PostCSS plugin chain
* fix(remote-desktop): stop unsolicited clipboard read prompts (#1482)
* fix(remote-desktop): read clipboard only on explicit paste
* test(css): exercise the configured PostCSS plugin chain
* test(identity): preserve full Ed25519 public keys in fixtures
* test(remote-desktop): always mutate ciphertext in tamper test
* chore: simplify plugin readmes, changelogs and manifest descriptions
* fix: keep plugins loaded after signing in from the login screen
* fix(file-manager): accept OS file drops over existing rows (#1484)
* fix(file-manager): accept OS file drops over existing rows
* test(file-manager): target the file label in drop tests
* test(css): exercise the configured PostCSS plugin chain
* test(identity): preserve full Ed25519 public keys in fixtures
* test(remote-desktop): always mutate ciphertext in tamper test
* fix(file-manager): pipeline SFTP download reads (#1485)
* feat: add plugin sdk build to beta release
* fix: make link-store secret check immune to random base64 matches
* fix(ldap): preserve the directory-provided bind DN (#1486)
* fix: compute beta changes across dev branches and move the beta tag
* chore: untrack plugin sdk ARCHITECTURE.md
* chore: remove references to plugin sdk ARCHITECTURE.md
* feat: merge host editor terminal tabs into one owned by ssh-terminal
* feat: add descriptions to plugin host enable toggles
* fix(file-manager): show download progress in file viewers (#1487)
* fix(electron): signal backend readiness over IPC (#1488)
* fix(split-screen): allow layout creation without randomUUID (#1490)
* fix(split-screen): allow layout creation without randomUUID
* test(credentials): avoid flaky Ed25519 key generation
* fix(sidebar): remeasure visible rows after density changes (#1489)
* fix(sidebar): remeasure visible rows after density changes
* test(credentials): avoid flaky Ed25519 key generation
* feat(split-screen): redesign split screen with free-form panes and pane picker
* feat(sidebar): add host click behavior setting, default to always opening a new tab
* feat(snippets): redesign panel to match the host list
* fix(session-recording): stop session logs panel from refetching in a loop
* feat(snippets): bring back sharing, target hosts and drag reorder
* feat(ssh-terminal): add toolbar position, start state, display and fade host settings
* feat(ssh-terminal): add host setting to turn off password prompt auto-fill
* fix(ai): stop streams getting cut off and keep tool steps across messages
* feat: improve quick connect system using plugin api
* fix: proxmox guest sync, startup snippet sync, drop dead cloudflare ssh transport
* feat: move terminal settings, look and ssh tools into ssh-terminal plugin
* feat: move snippets, keybinding actions and macros out of core into plugins
* feat: store rdp, vnc and telnet logins in a generic per-protocol table
* feat: type the plugin host record, move plugin strings out of core and add lint checks
* feat: replace core homepage widget registry with generic extension points
* feat: plugins only see their own host settings in the browser
* feat: harden plugin api for separate repos, signed updates and generic external login
* fix: keep plugin css below core utilities and version plugin assets by their css
* fix: load and save plugin host settings in the editor and tighten settings row spacing
* feat: redesign user host defaults system
* fix(remote-desktop): release held keys on focus loss (#1498)
* fix(session-sharing): replace local presentation after takeover (#1500)
* fix(file-manager): refresh disk usage with directory listing (#1503)
* fix(ssh-terminal): preserve input order during local echo reconciliation (#1505)
* feat(remote-desktop): expose display zoom controls for RDP (#1514)
* fix(file-manager): restore text selection and copying in Markdown previews (#1518)
* fix(sidebar): keep compact host addresses visible (#1524)
* fix(hosts): preserve plugin settings when reopening the editor (#1499)
* fix(ssh-terminal): close owner sockets when presentations unmount (#1501)
* fix(session-sharing): synchronize shared SSH terminal dimensions (#1502)
* fix(session-sharing): show participant presence in member terminals (#1504)
* fix(ai): sync provider configuration and keys across linked devices (#1506)
* feat(ssh-terminal): add a duplicate tab action (#1510)
* feat(file-manager): allow disabling move-to-trash confirmation (#1511)
* feat(file-manager): default to the remote login directory (#1512)
* feat(homepage): synchronize canvas layouts across devices (#1515)
* fix(shortcuts): prevent accidental double-Shift palette activation (#1519)
* feat(tmux-monitor): add a unified multi-host view (#1520)
* fix(electron): allow explicit quit with active connections (#1522)
* feat: reconnect all disconnected terminal tabs (#1523)
* fix(hosts): preserve recording and sharing settings in the dev editor (#1509)
* fix(database): preserve RDP domain during startup backfill (#1497)
* feat(sidebar): add keyboard type-ahead search for hosts (#1516)
* feat(automations): add per-host maintenance mode and recurring schedules (#1521)
* feat(tmux): add a per-host mouse toggle and preserve remote configuration (#1513)
* fix(session-sharing): use the linked server for desktop meetings and links (#1507)
* fix(tunnels): support TOTP for client tunnels and jump hosts (#1508)
* fix: type errors and lint failures from merged plugin prs
* feat(installer): make the Windows desktop shortcut optional (#1517)
* fix: ship the plugin sdk and serialport in desktop builds
* fix: prefer ipv4 when resolving ssh host names (#1365)
* fix: readable terminal selection with the light theme (#1319)
* fix: build desktop session share links on the linked server (#1350)
* fix: show meeting guests to members and hide the roster from guests (#1353)
* fix: reliable file manager saves with sudo prompt and no base64 guessing (#1335)
* fix: show disk usage for the mount being browsed (#1347)
* fix: load the linux tray icon reliably and log tray failures (#1332)
* fix: cover the gnome close path in the desktop quit test (#1332)
* fix: prompt for jump host TOTP in terminal, file manager and metrics (#1312)
* feat: optional auto reconnect for dropped ssh sessions (#1321)
* feat: tighter compact host rows with inline tags (#1325)
* feat: bring back the alert feed homepage widget
* feat: pick target terminals for snippets again
* feat: share button on connection tabs again
* feat: recent servers list when linking the desktop app
* feat: list the fixed app shortcuts in keyboard shortcuts
* fix: translate hardcoded toasts and drop em dashes from ui text
* fix: translate leftover hardcoded ui text
* fix: toolbar files button opens at the shell directory again
* fix: show the remote desktop note under connection origin again
* chore: openapi docs for host metrics manager routes
* chore: openapi docs for undocumented routes and fix two broken doc blocks
* fix: declare terminal.listSessions use for snippet targets
* revert: drop the alert feed widget, the notification center replaces it
* feat: restore the alert feed homepage widget
* fix: quick connect fills the host address from plugin auth editors like tailscale
* fix: docker container logs use the base background color
* chore: fix dependabot alerts and apply safe npm upgrades
* fix: proxmox stats tab reads its switch from plugin host settings
* fix: count plugin ssh logins toward host status and stop showing reachable as a warning
* fix: hide the built-in source pill in the host editor
* fix: host status shows online when the port answers and only warns on a failed login
* fix: drop the top border on the split layout menu
* fix: host defaults tabs sit where the host editor puts them and skip plugins with nothing to default
* fix: remote desktop auth method labels and notes for vnc and telnet
* fix: add description to the web endpoint enable switch
* fix: crowdin sync and pretranslate for plugin locales, run plugin tests on release
* feat: move telemetry out of core into a usage statistics plugin
* fix: recent activity card no longer cuts off host names early
* fix: remove duplicate top border on split screen menu
* fix: redesign session log player controls, fix tooltip overlap and drop dot separators
* fix: file manager and sftp text showing raw i18n keys
* fix: onboarding rerunning for existing users after upgrading
* fix: fleet detail buttons overflowing the sidebar
* fix: session log player scrolling off screen horizontally
* fix: network graph lag when adding hosts and on every render
* fix: maintenance index name, shared host read only view and badge polling
* fix: meeting tabs, workspace tab merging, rail panels as tabs and general ui lag
* chore: update release notes
* fix: remote desktop tabs reconnecting on every tab switch
* fix: build plugin sdk before linting in release workflow
* chore: lint, format, and bump version to 2.9.0
* chore: skip crowdin pre-translate in release for now
* chore: sync Crowdin translations for 2.9.0
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Koi <38512047+datlt4@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com>
This commit is contained in:
4405 files changed
+1341026
-289722
No files matched your search
@@ -0,0 +1,56 @@
|
||||
import { createRequire } from "node:module";
|
||||
import fs from "node:fs";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
import { afterEach, describe, expect, it } from "vitest";
|
||||
|
||||
const require = createRequire(import.meta.url);
|
||||
const { copyPluginSdk } =
|
||||
require("../../../../packaging/build/after-pack.cjs") as {
|
||||
copyPluginSdk: (resourcesDir: string, sdkDir?: string) => string;
|
||||
};
|
||||
|
||||
let dir: string;
|
||||
afterEach(() => {
|
||||
if (dir) fs.rmSync(dir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
describe("afterPack plugin SDK copy", () => {
|
||||
it("ships the SDK package.json and dist where the packaged backend resolves it", () => {
|
||||
dir = fs.mkdtempSync(path.join(os.tmpdir(), "termix-after-pack-"));
|
||||
const sdk = path.join(dir, "sdk");
|
||||
fs.mkdirSync(path.join(sdk, "dist"), { recursive: true });
|
||||
fs.mkdirSync(path.join(sdk, "src"));
|
||||
fs.writeFileSync(
|
||||
path.join(sdk, "package.json"),
|
||||
'{"name":"@termix/plugin-sdk"}',
|
||||
);
|
||||
fs.writeFileSync(path.join(sdk, "dist", "settings.js"), "export {};");
|
||||
fs.writeFileSync(path.join(sdk, "src", "settings.ts"), "");
|
||||
const resources = path.join(dir, "resources");
|
||||
|
||||
const target = copyPluginSdk(resources, sdk);
|
||||
|
||||
expect(target).toBe(
|
||||
path.join(
|
||||
resources,
|
||||
"app.asar.unpacked",
|
||||
"node_modules",
|
||||
"@termix",
|
||||
"plugin-sdk",
|
||||
),
|
||||
);
|
||||
expect(fs.readdirSync(target).sort()).toEqual(["dist", "package.json"]);
|
||||
expect(fs.existsSync(path.join(target, "dist", "settings.js"))).toBe(true);
|
||||
});
|
||||
|
||||
it("stops the build when the SDK was never built", () => {
|
||||
dir = fs.mkdtempSync(path.join(os.tmpdir(), "termix-after-pack-"));
|
||||
const sdk = path.join(dir, "sdk");
|
||||
fs.mkdirSync(sdk);
|
||||
fs.writeFileSync(path.join(sdk, "package.json"), "{}");
|
||||
expect(() => copyPluginSdk(path.join(dir, "resources"), sdk)).toThrow(
|
||||
"npm run build:sdk",
|
||||
);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,117 @@
|
||||
import { EventEmitter } from "node:events";
|
||||
import fs from "node:fs";
|
||||
import vm from "node:vm";
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
const main = fs.readFileSync(
|
||||
new URL("../../../../electron/main.cjs", import.meta.url),
|
||||
"utf8",
|
||||
);
|
||||
const shell = fs.readFileSync(
|
||||
new URL("../../../ui/AppShell.tsx", import.meta.url),
|
||||
"utf8",
|
||||
);
|
||||
|
||||
function harness(
|
||||
active = true,
|
||||
hasTray = true,
|
||||
platform: { platform: string; env: Record<string, string> } = {
|
||||
platform: "win32",
|
||||
env: {},
|
||||
},
|
||||
) {
|
||||
const app = new EventEmitter();
|
||||
const window = Object.assign(new EventEmitter(), {
|
||||
webContents: new EventEmitter(),
|
||||
hide: vi.fn(),
|
||||
minimize: vi.fn(),
|
||||
});
|
||||
const context = vm.createContext({
|
||||
isQuitting: false,
|
||||
app,
|
||||
mainWindow: window,
|
||||
console,
|
||||
process: platform,
|
||||
tray: hasTray ? { isDestroyed: () => false } : null,
|
||||
hasActiveConnection: () => active,
|
||||
});
|
||||
// Run the production registrations together, sharing the actual quit flag.
|
||||
vm.runInContext(
|
||||
main.slice(
|
||||
main.indexOf(' mainWindow.webContents.on("did-finish-load"'),
|
||||
main.indexOf(" mainWindow.webContents.setWindowOpenHandler"),
|
||||
),
|
||||
context,
|
||||
);
|
||||
vm.runInContext(
|
||||
main.slice(
|
||||
main.indexOf('app.on("before-quit"'),
|
||||
main.indexOf('app.on("will-quit"'),
|
||||
),
|
||||
context,
|
||||
);
|
||||
const unload = shell.slice(
|
||||
shell.indexOf(" const handleBeforeUnload ="),
|
||||
shell.indexOf(' window.addEventListener("beforeunload"'),
|
||||
);
|
||||
vm.runInContext(
|
||||
unload.replace("(event: BeforeUnloadEvent)", "(event)") +
|
||||
"\nglobalThis.unload = handleBeforeUnload;",
|
||||
context,
|
||||
);
|
||||
const rendererUnload = () => {
|
||||
const event = { preventDefault: vi.fn(), returnValue: undefined };
|
||||
context.unload(event);
|
||||
return event.preventDefault.mock.calls.length > 0;
|
||||
};
|
||||
function attemptQuit() {
|
||||
app.emit("before-quit");
|
||||
const close = { preventDefault: vi.fn() };
|
||||
window.emit("close", close);
|
||||
if (close.preventDefault.mock.calls.length) return false;
|
||||
if (!rendererUnload()) return true;
|
||||
const prevented = { preventDefault: vi.fn() };
|
||||
window.webContents.emit("will-prevent-unload", prevented);
|
||||
return prevented.preventDefault.mock.calls.length > 0;
|
||||
}
|
||||
return { window, rendererUnload, attemptQuit };
|
||||
}
|
||||
|
||||
describe("desktop quit with active connections", () => {
|
||||
it.each([true, false])(
|
||||
"allows explicit quit when the renderer vetoes unloading (tray: %s)",
|
||||
(hasTray) => {
|
||||
const app = harness(true, hasTray);
|
||||
expect(app.attemptQuit()).toBe(true);
|
||||
expect(app.window.hide).not.toHaveBeenCalled();
|
||||
},
|
||||
);
|
||||
it("keeps the unload guard during ordinary navigation or reload", () => {
|
||||
const app = harness();
|
||||
expect(app.rendererUnload()).toBe(true);
|
||||
const event = { preventDefault: vi.fn() };
|
||||
app.window.webContents.emit("will-prevent-unload", event);
|
||||
expect(event.preventDefault).not.toHaveBeenCalled();
|
||||
});
|
||||
it("continues hiding ordinary window closes in the tray", () => {
|
||||
const app = harness();
|
||||
const event = { preventDefault: vi.fn() };
|
||||
app.window.emit("close", event);
|
||||
expect(event.preventDefault).toHaveBeenCalledOnce();
|
||||
expect(app.window.hide).toHaveBeenCalledOnce();
|
||||
});
|
||||
it("minimizes instead of hiding on GNOME, which has no tray by default", () => {
|
||||
const app = harness(true, true, {
|
||||
platform: "linux",
|
||||
env: { XDG_CURRENT_DESKTOP: "ubuntu:GNOME" },
|
||||
});
|
||||
const event = { preventDefault: vi.fn() };
|
||||
app.window.emit("close", event);
|
||||
expect(event.preventDefault).toHaveBeenCalledOnce();
|
||||
expect(app.window.minimize).toHaveBeenCalledOnce();
|
||||
expect(app.window.hide).not.toHaveBeenCalled();
|
||||
});
|
||||
it("quits normally when no connection blocks unloading", () => {
|
||||
expect(harness(false).attemptQuit()).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,86 @@
|
||||
import { createRequire } from "node:module";
|
||||
import { EventEmitter } from "node:events";
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
const require = createRequire(import.meta.url);
|
||||
const { createC2SAuthBridge } = require("../../../../electron/c2s-auth.cjs");
|
||||
|
||||
function setup() {
|
||||
const sender = Object.assign(new EventEmitter(), {
|
||||
send: vi.fn(),
|
||||
isDestroyed: () => false,
|
||||
});
|
||||
const ws = Object.assign(new EventEmitter(), {
|
||||
readyState: 1,
|
||||
send: vi.fn(),
|
||||
close: vi.fn(() => {
|
||||
ws.readyState = 3;
|
||||
ws.emit("close");
|
||||
}),
|
||||
});
|
||||
let answer!: (
|
||||
event: { sender: unknown },
|
||||
id: string,
|
||||
value: unknown,
|
||||
) => boolean;
|
||||
const attach = createC2SAuthBridge(
|
||||
{
|
||||
handle: (_name: string, fn: typeof answer) => {
|
||||
answer = fn;
|
||||
},
|
||||
},
|
||||
() => ({ isDestroyed: () => false, webContents: sender }),
|
||||
);
|
||||
attach(ws, "dynamic");
|
||||
const prompt = () =>
|
||||
ws.emit(
|
||||
"message",
|
||||
Buffer.from(
|
||||
JSON.stringify({
|
||||
type: "auth-prompt",
|
||||
requestId: "server-challenge",
|
||||
request: { kind: "totp", prompt: "Code:", retry: false },
|
||||
}),
|
||||
),
|
||||
false,
|
||||
);
|
||||
return { sender, ws, answer, prompt };
|
||||
}
|
||||
afterEach(() => vi.useRealTimers());
|
||||
describe("desktop tunnel prompt bridge", () => {
|
||||
it("binds answers to the renderer and challenge, and rejects replay", () => {
|
||||
const { sender, ws, answer, prompt } = setup();
|
||||
prompt();
|
||||
const id = sender.send.mock.calls[0][1].id;
|
||||
expect(answer({ sender: {} }, id, "123456")).toBe(false);
|
||||
expect(answer({ sender }, "unknown", "123456")).toBe(false);
|
||||
expect(answer({ sender }, id, { secret: "bad" })).toBe(false);
|
||||
expect(ws.send).not.toHaveBeenCalled();
|
||||
expect(answer({ sender }, id, "123456")).toBe(true);
|
||||
expect(JSON.parse(ws.send.mock.calls[0][0])).toEqual({
|
||||
type: "auth-response",
|
||||
requestId: "server-challenge",
|
||||
answer: "123456",
|
||||
});
|
||||
expect(answer({ sender }, id, "again")).toBe(false);
|
||||
expect(sender.listenerCount("destroyed")).toBe(0);
|
||||
ws.close();
|
||||
});
|
||||
it.each(["close", "reload", "timeout"])(
|
||||
"clears a pending dialog on %s",
|
||||
(reason) => {
|
||||
vi.useFakeTimers();
|
||||
const { sender, ws, answer, prompt } = setup();
|
||||
prompt();
|
||||
const id = sender.send.mock.calls[0][1].id;
|
||||
if (reason === "close") ws.close();
|
||||
else if (reason === "reload") sender.emit("did-start-loading");
|
||||
else vi.advanceTimersByTime(60_000);
|
||||
expect(sender.send).toHaveBeenLastCalledWith("c2s-auth-prompt", {
|
||||
id,
|
||||
closed: true,
|
||||
});
|
||||
expect(answer({ sender }, id, "late")).toBe(false);
|
||||
expect(ws.close).toHaveBeenCalled();
|
||||
},
|
||||
);
|
||||
});
|
||||
@@ -0,0 +1,143 @@
|
||||
import { EventEmitter } from "node:events";
|
||||
import { readFileSync } from "node:fs";
|
||||
import vm from "node:vm";
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
const main = readFileSync(
|
||||
new URL("../../../../electron/main.cjs", import.meta.url),
|
||||
"utf8",
|
||||
);
|
||||
const section = (from: string, to: string) =>
|
||||
main.slice(main.indexOf(from), main.indexOf(to, main.indexOf(from)));
|
||||
function setup() {
|
||||
const sockets: Socket[] = [];
|
||||
class Socket extends EventEmitter {
|
||||
readyState = 1;
|
||||
send = vi.fn();
|
||||
close = vi.fn(() => {
|
||||
if (this.readyState === 3) return;
|
||||
this.readyState = 3;
|
||||
this.emit("close");
|
||||
});
|
||||
constructor() {
|
||||
super();
|
||||
sockets.push(this);
|
||||
queueMicrotask(() => this.emit("open"));
|
||||
}
|
||||
ready() {
|
||||
this.emit(
|
||||
"message",
|
||||
Buffer.from(JSON.stringify({ type: "ready" })),
|
||||
false,
|
||||
);
|
||||
}
|
||||
}
|
||||
const runtimes = new Map();
|
||||
let incoming!: (socket: EventEmitter) => void;
|
||||
const server = Object.assign(new EventEmitter(), {
|
||||
listen: (_options: unknown, ready: () => void) => ready(),
|
||||
close: vi.fn((done?: () => void) => done?.()),
|
||||
});
|
||||
const headers = vi.fn(async () => ({}));
|
||||
const dynamic = vi.fn();
|
||||
const context = vm.createContext({
|
||||
setTimeout,
|
||||
clearTimeout,
|
||||
WebSocket: Socket,
|
||||
crypto: { randomUUID: () => "runtime-token" },
|
||||
net: {
|
||||
createServer: (callback: typeof incoming) => {
|
||||
incoming = callback;
|
||||
return server;
|
||||
},
|
||||
},
|
||||
c2sTunnelRuntimes: runtimes,
|
||||
normalizeC2STunnelAddresses: (t: unknown) => t,
|
||||
resolveC2SRemoteSourceHost: async (t: unknown) => t,
|
||||
getC2STunnelName: (t: { name: string }) => t.name,
|
||||
getC2SLocalAddress: () => "127.0.0.1",
|
||||
getC2SRemoteAddress: () => "127.0.0.1",
|
||||
getC2SRelayUrl: () => "wss://server/relay",
|
||||
getC2SRelayHeaders: headers,
|
||||
getWebSocketOptions: (_url: string, options: unknown) => options,
|
||||
attachC2SAuth: vi.fn(),
|
||||
logToFile: vi.fn(),
|
||||
emitC2STunnelStatuses: vi.fn(),
|
||||
checkLocalPortAvailable: async () => ({ available: true }),
|
||||
handleC2SDynamicConnection: dynamic,
|
||||
setC2STunnelStatus: (name: string, status: unknown) => {
|
||||
runtimes.get(name).status = status;
|
||||
},
|
||||
setC2STunnelError: (name: string, error: string) => {
|
||||
runtimes.get(name).status = { connected: false, reason: error };
|
||||
},
|
||||
createC2SFailure: (error: string) => ({ success: false, error }),
|
||||
});
|
||||
vm.runInContext(
|
||||
section("async function testC2SRelay(", "async function testC2STunnel(") +
|
||||
section("async function startC2STunnel(", "function stopAllC2STunnels("),
|
||||
context,
|
||||
);
|
||||
return {
|
||||
context,
|
||||
runtimes,
|
||||
sockets,
|
||||
server,
|
||||
headers,
|
||||
dynamic,
|
||||
incoming: () => incoming,
|
||||
};
|
||||
}
|
||||
|
||||
describe("client tunnel runtime authentication", () => {
|
||||
it("holds preflight open, shares its runtime identity and token, and releases it when stopped", async () => {
|
||||
const { context, runtimes, sockets, server, headers, dynamic, incoming } =
|
||||
setup();
|
||||
const tunnel = {
|
||||
name: "socks",
|
||||
mode: "dynamic",
|
||||
sourceHostId: 7,
|
||||
sourcePort: 1080,
|
||||
};
|
||||
await context.startC2STunnel(tunnel, 0, "local-auth");
|
||||
await vi.waitFor(() => expect(sockets).toHaveLength(1));
|
||||
const premature = Object.assign(new EventEmitter(), { destroy: vi.fn() });
|
||||
incoming()(premature);
|
||||
expect(premature.destroy).toHaveBeenCalledOnce();
|
||||
expect(headers).toHaveBeenCalledWith("wss://server/relay", "local-auth");
|
||||
expect(JSON.parse(sockets[0].send.mock.calls[0][0])).toMatchObject({
|
||||
keepAlive: true,
|
||||
tunnelConfig: { sessionId: "runtime-token" },
|
||||
});
|
||||
sockets[0].ready();
|
||||
await vi.waitFor(() =>
|
||||
expect(runtimes.get("socks").status.connected).toBe(true),
|
||||
);
|
||||
expect(sockets[0].close).not.toHaveBeenCalled();
|
||||
const client = Object.assign(new EventEmitter(), { destroy: vi.fn() });
|
||||
incoming()(client);
|
||||
expect(dynamic).toHaveBeenCalledWith(
|
||||
expect.objectContaining({ sessionId: "runtime-token" }),
|
||||
client,
|
||||
"local-auth",
|
||||
);
|
||||
await context.stopC2STunnel("socks");
|
||||
expect(sockets[0].close).toHaveBeenCalledOnce();
|
||||
expect(client.destroy).toHaveBeenCalledOnce();
|
||||
expect(server.close).toHaveBeenCalledOnce();
|
||||
expect(runtimes.size).toBe(0);
|
||||
});
|
||||
|
||||
it("does not retain a socket for a standalone test or a stopped runtime", async () => {
|
||||
const { context, sockets } = setup();
|
||||
const test = context.testC2SRelay({ name: "test" });
|
||||
await vi.waitFor(() => expect(sockets).toHaveLength(1));
|
||||
sockets[0].ready();
|
||||
expect(await test).toEqual({ success: true });
|
||||
expect(sockets[0].close).toHaveBeenCalledOnce();
|
||||
expect(
|
||||
await context.testC2SRelay({ name: "stopped" }, null, null, null, {}),
|
||||
).toEqual({ success: false, error: "Tunnel stopped" });
|
||||
expect(sockets).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
+27
-24
@@ -1,8 +1,8 @@
|
||||
import { createRequire } from "node:module";
|
||||
import { EventEmitter } from "node:events";
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
const { createWebEndpointWindows } = createRequire(import.meta.url)(
|
||||
"../../../../electron/web-endpoint-window.cjs",
|
||||
const { createIsolatedWindows } = createRequire(import.meta.url)(
|
||||
"../../../../electron/isolated-window.cjs",
|
||||
);
|
||||
const created: FakeWindow[] = [];
|
||||
class FakeWindow extends EventEmitter {
|
||||
@@ -38,10 +38,7 @@ type TestSession = EventEmitter & {
|
||||
};
|
||||
let sessions: TestSession[];
|
||||
let fromPartition: ReturnType<typeof vi.fn>;
|
||||
let manager: ReturnType<typeof createWebEndpointWindows>;
|
||||
function event() {
|
||||
return { sender: main.webContents, senderFrame: main.webContents.mainFrame };
|
||||
}
|
||||
let manager: ReturnType<typeof createIsolatedWindows>;
|
||||
beforeEach(() => {
|
||||
created.length = 0;
|
||||
sessions = [];
|
||||
@@ -59,16 +56,16 @@ beforeEach(() => {
|
||||
sessions.push(session);
|
||||
return session;
|
||||
});
|
||||
manager = createWebEndpointWindows({
|
||||
manager = createIsolatedWindows({
|
||||
BrowserWindow: FakeWindow,
|
||||
session: { fromPartition },
|
||||
getMainWindow: () => main,
|
||||
});
|
||||
});
|
||||
describe("isolated endpoint windows", () => {
|
||||
describe("isolated windows", () => {
|
||||
it("creates unique non-persistent sessions without preload or Node privileges", async () => {
|
||||
await manager.open(event(), { url: "https://service.test" });
|
||||
await manager.open(event(), { url: "https://service.test" });
|
||||
await manager.open({ url: "https://service.test" });
|
||||
await manager.open({ url: "https://service.test" });
|
||||
expect(fromPartition.mock.calls[0][0]).not.toBe(
|
||||
fromPartition.mock.calls[1][0],
|
||||
);
|
||||
@@ -82,27 +79,33 @@ describe("isolated endpoint windows", () => {
|
||||
webSecurity: true,
|
||||
});
|
||||
});
|
||||
it("rejects subframes, other windows and non-web destinations before creating a session", async () => {
|
||||
await expect(
|
||||
manager.open(
|
||||
{ ...event(), senderFrame: {} },
|
||||
{ url: "https://service.test" },
|
||||
),
|
||||
).rejects.toThrow(/main Termix/);
|
||||
await expect(
|
||||
manager.open({ ...event(), sender: {} }, { url: "https://service.test" }),
|
||||
).rejects.toThrow(/main Termix/);
|
||||
it("uses a caller-supplied partition when given one", async () => {
|
||||
await manager.open({ url: "https://service.test", partition: "fixed" });
|
||||
expect(fromPartition.mock.calls[0][0]).toBe("fixed");
|
||||
});
|
||||
it("rejects non-web destinations before creating a session", async () => {
|
||||
for (const url of [
|
||||
"file:///etc/passwd",
|
||||
"javascript:alert(1)",
|
||||
"https://user:secret@service.test",
|
||||
]) {
|
||||
await expect(manager.open(event(), { url })).rejects.toThrow();
|
||||
await expect(manager.open({ url })).rejects.toThrow();
|
||||
}
|
||||
expect(fromPartition).not.toHaveBeenCalled();
|
||||
});
|
||||
it("refuses when there is no window to attach to", async () => {
|
||||
manager = createIsolatedWindows({
|
||||
BrowserWindow: FakeWindow,
|
||||
session: { fromPartition },
|
||||
getMainWindow: () => null,
|
||||
});
|
||||
await expect(manager.open({ url: "https://service.test" })).rejects.toThrow(
|
||||
/No window/,
|
||||
);
|
||||
expect(fromPartition).not.toHaveBeenCalled();
|
||||
});
|
||||
it("keeps login popups in the same isolated session and blocks native-protocol navigation", async () => {
|
||||
await manager.open(event(), { url: "https://service.test" });
|
||||
await manager.open({ url: "https://service.test" });
|
||||
const win = created[0],
|
||||
open = win.webContents.setWindowOpenHandler.mock.calls[0][0];
|
||||
expect(
|
||||
@@ -121,7 +124,7 @@ describe("isolated endpoint windows", () => {
|
||||
expect(callback).toHaveBeenCalledWith({ cancel: true });
|
||||
});
|
||||
it("limits invalid certificates to the opted-in origin, including its port", async () => {
|
||||
await manager.open(event(), {
|
||||
await manager.open({
|
||||
url: "https://service.test:8443",
|
||||
ignoreCert: true,
|
||||
});
|
||||
@@ -153,7 +156,7 @@ describe("isolated endpoint windows", () => {
|
||||
).toBe(false);
|
||||
});
|
||||
it("closes login popups and clears session data when the endpoint closes", async () => {
|
||||
await manager.open(event(), { url: "https://service.test" });
|
||||
await manager.open({ url: "https://service.test" });
|
||||
const root = created[0],
|
||||
popup = new FakeWindow({});
|
||||
root.webContents.emit("did-create-window", popup);
|
||||
@@ -0,0 +1,85 @@
|
||||
import { createRequire } from "node:module";
|
||||
import { beforeEach, describe, expect, it } from "vitest";
|
||||
|
||||
const require = createRequire(import.meta.url);
|
||||
const linked = require("../../../../electron/linked-server.cjs") as {
|
||||
setLinkedServer: (config: unknown) => void;
|
||||
getLinkedServer: () => Record<string, unknown> | null;
|
||||
isLinkedOrigin: (url: string) => boolean;
|
||||
applyLinkHeaders: (
|
||||
url: string,
|
||||
headers: Record<string, string>,
|
||||
) => Record<string, string>;
|
||||
linkedRequestHeaders: (
|
||||
extra?: Record<string, string>,
|
||||
) => Record<string, string>;
|
||||
answerLogin: (
|
||||
authInfo: { isProxy?: boolean } | null,
|
||||
url: string,
|
||||
) => { username: string; password: string } | null;
|
||||
};
|
||||
|
||||
const ORIGIN = "https://termix.example";
|
||||
|
||||
beforeEach(() => {
|
||||
linked.setLinkedServer(null);
|
||||
});
|
||||
|
||||
describe("linked server in Electron main", () => {
|
||||
it("adds proxy headers only for the linked origin", () => {
|
||||
linked.setLinkedServer({
|
||||
origin: ORIGIN,
|
||||
headers: [{ name: "CF-Access-Client-Id", value: "id" }],
|
||||
});
|
||||
expect(
|
||||
linked.applyLinkHeaders(`${ORIGIN}/sync/v2/info`, { Accept: "x" }),
|
||||
).toEqual({ Accept: "x", "CF-Access-Client-Id": "id" });
|
||||
expect(
|
||||
linked.applyLinkHeaders("https://elsewhere.example/", { Accept: "x" }),
|
||||
).toEqual({ Accept: "x" });
|
||||
});
|
||||
|
||||
it("moves a Termix bearer into the jwt cookie when basic auth is in front", () => {
|
||||
linked.setLinkedServer({
|
||||
origin: ORIGIN,
|
||||
basicAuth: { username: "gate", password: "pw" },
|
||||
});
|
||||
const headers = linked.applyLinkHeaders(`${ORIGIN}/host/status`, {
|
||||
authorization: "Bearer tok",
|
||||
Cookie: "a=b",
|
||||
});
|
||||
expect(headers.Authorization).toBe(
|
||||
`Basic ${Buffer.from("gate:pw").toString("base64")}`,
|
||||
);
|
||||
expect(headers.authorization).toBeUndefined();
|
||||
expect(headers.Cookie).toBe("a=b; jwt=tok");
|
||||
});
|
||||
|
||||
it("builds main's own request headers with the session", () => {
|
||||
linked.setLinkedServer({ origin: ORIGIN, token: "tok" });
|
||||
expect(linked.linkedRequestHeaders()).toEqual({
|
||||
"X-Electron-App": "true",
|
||||
Authorization: "Bearer tok",
|
||||
});
|
||||
});
|
||||
|
||||
it("answers basic auth challenges from the linked origin only", () => {
|
||||
linked.setLinkedServer({
|
||||
origin: ORIGIN,
|
||||
basicAuth: { username: "gate", password: "pw" },
|
||||
});
|
||||
expect(linked.answerLogin({}, `${ORIGIN}/`)).toEqual({
|
||||
username: "gate",
|
||||
password: "pw",
|
||||
});
|
||||
expect(linked.answerLogin({ isProxy: true }, `${ORIGIN}/`)).toBeNull();
|
||||
expect(linked.answerLogin({}, "https://other.example/")).toBeNull();
|
||||
});
|
||||
|
||||
it("forgets everything on unlink", () => {
|
||||
linked.setLinkedServer({ origin: ORIGIN, token: "tok" });
|
||||
linked.setLinkedServer(null);
|
||||
expect(linked.getLinkedServer()).toBeNull();
|
||||
expect(linked.isLinkedOrigin(`${ORIGIN}/`)).toBe(false);
|
||||
});
|
||||
});
|
||||
@@ -44,8 +44,10 @@ const localFiles = require("../../../../electron/local-files.cjs") as {
|
||||
TRANSFER_ROUTES: Record<string, string>;
|
||||
createTargetResolver: (deps: {
|
||||
localBaseUrl?: string;
|
||||
getRemoteSyncConfig?: () => { serverUrl?: string } | null;
|
||||
getRemoteSyncJwt?: () => string | null;
|
||||
getLinkedServer?: () => {
|
||||
serverUrl?: string;
|
||||
token?: string | null;
|
||||
} | null;
|
||||
}) => (req: { origin?: unknown; route?: unknown; deviceId?: unknown }) => {
|
||||
url: string;
|
||||
headers: Record<string, string>;
|
||||
@@ -53,8 +55,10 @@ const localFiles = require("../../../../electron/local-files.cjs") as {
|
||||
createLocalFileHandlers: (deps: {
|
||||
net: unknown;
|
||||
shell: unknown;
|
||||
getRemoteSyncConfig?: () => { serverUrl?: string } | null;
|
||||
getRemoteSyncJwt?: () => string | null;
|
||||
getLinkedServer?: () => {
|
||||
serverUrl?: string;
|
||||
token?: string | null;
|
||||
} | null;
|
||||
localBaseUrl?: string;
|
||||
publishFs?: PublishFs;
|
||||
}) => Record<
|
||||
@@ -128,7 +132,7 @@ function startBackend(
|
||||
let body = "";
|
||||
req.on("data", (d) => (body += d));
|
||||
req.on("end", () => {
|
||||
if (!opts.failAll && req.url?.endsWith("/ssh/downloadFileStream")) {
|
||||
if (!opts.failAll && req.url?.endsWith("/downloadFileStream")) {
|
||||
// Headers go out immediately so the client opens its temp file;
|
||||
// the body may be delayed to keep the transfer in flight.
|
||||
res.writeHead(200, { "Content-Length": payload.length });
|
||||
@@ -150,7 +154,7 @@ function startBackend(
|
||||
server.listen(0, "127.0.0.1", () => {
|
||||
const address = server.address() as { port: number };
|
||||
resolve({
|
||||
url: `http://127.0.0.1:${address.port}/ssh/file_manager`,
|
||||
url: `http://127.0.0.1:${address.port}/plugin-api/file-manager`,
|
||||
seen,
|
||||
close: () => new Promise((r) => server.close(() => r())),
|
||||
});
|
||||
@@ -160,25 +164,28 @@ function startBackend(
|
||||
|
||||
describe("local-files transfer target resolution", () => {
|
||||
const resolve = localFiles.createTargetResolver({
|
||||
localBaseUrl: "http://127.0.0.1:30004/ssh/file_manager",
|
||||
getRemoteSyncConfig: () => ({ serverUrl: "https://termix.example.com/" }),
|
||||
getRemoteSyncJwt: () => "remote-jwt",
|
||||
localBaseUrl: "http://127.0.0.1:30001/plugin-api/file-manager",
|
||||
apiPath: "/plugin-api/file-manager",
|
||||
getLinkedServer: () => ({
|
||||
serverUrl: "https://termix.example.com/",
|
||||
token: "remote-jwt",
|
||||
}),
|
||||
});
|
||||
|
||||
it("only reaches the two file-manager streaming routes on the local backend", () => {
|
||||
expect(resolve({ origin: "local", route: "uploadFileStream" })).toEqual({
|
||||
url: "http://127.0.0.1:30004/ssh/file_manager/ssh/uploadFileStream",
|
||||
url: "http://127.0.0.1:30001/plugin-api/file-manager/uploadFileStream",
|
||||
headers: { "X-Electron-App": "true" },
|
||||
});
|
||||
expect(resolve({ origin: "local", route: "downloadFileStream" }).url).toBe(
|
||||
"http://127.0.0.1:30004/ssh/file_manager/ssh/downloadFileStream",
|
||||
"http://127.0.0.1:30001/plugin-api/file-manager/downloadFileStream",
|
||||
);
|
||||
});
|
||||
|
||||
it("derives the remote target from the configured sync server and attaches its JWT itself", () => {
|
||||
it("derives the remote target from the linked server and attaches its session itself", () => {
|
||||
const target = resolve({ origin: "remote", route: "downloadFileStream" });
|
||||
expect(target.url).toBe(
|
||||
"https://termix.example.com/ssh/file_manager/ssh/downloadFileStream",
|
||||
"https://termix.example.com/plugin-api/file-manager/downloadFileStream",
|
||||
);
|
||||
expect(target.headers.Authorization).toBe("Bearer remote-jwt");
|
||||
});
|
||||
@@ -196,15 +203,15 @@ describe("local-files transfer target resolution", () => {
|
||||
expect(() => resolve({})).toThrow(/Unknown transfer route/);
|
||||
});
|
||||
|
||||
it("refuses a remote origin when no sync server is configured or it is not http(s)", () => {
|
||||
it("refuses a remote origin when the device is not linked or the server is not http(s)", () => {
|
||||
const unconfigured = localFiles.createTargetResolver({
|
||||
getRemoteSyncConfig: () => null,
|
||||
getLinkedServer: () => null,
|
||||
});
|
||||
expect(() =>
|
||||
unconfigured({ origin: "remote", route: "uploadFileStream" }),
|
||||
).toThrow(/not configured/);
|
||||
).toThrow(/not linked/);
|
||||
const bogus = localFiles.createTargetResolver({
|
||||
getRemoteSyncConfig: () => ({ serverUrl: "file:///etc/passwd" }),
|
||||
getLinkedServer: () => ({ serverUrl: "file:///etc/passwd" }),
|
||||
});
|
||||
expect(() =>
|
||||
bogus({ origin: "remote", route: "uploadFileStream" }),
|
||||
@@ -242,7 +249,7 @@ describe("local-files transfer target resolution", () => {
|
||||
});
|
||||
expect(target.headers.Authorization).toBe(`Bearer ${jwt}`);
|
||||
expect(target.url).toBe(
|
||||
"http://127.0.0.1:30004/ssh/file_manager/ssh/uploadFileStream",
|
||||
"http://127.0.0.1:30001/plugin-api/file-manager/uploadFileStream",
|
||||
);
|
||||
// Absent or empty: no header at all (the session cookie is the fallback).
|
||||
for (const authToken of [undefined, null, ""]) {
|
||||
@@ -290,8 +297,7 @@ describe("local-files download boundary", () => {
|
||||
net: fakeNet,
|
||||
shell: {},
|
||||
localBaseUrl: backend.url,
|
||||
getRemoteSyncConfig: () => null,
|
||||
getRemoteSyncJwt: () => null,
|
||||
getLinkedServer: () => null,
|
||||
});
|
||||
});
|
||||
afterAll(() => backend.close());
|
||||
@@ -355,7 +361,7 @@ describe("local-files download boundary", () => {
|
||||
});
|
||||
expect(result.success).toBe(true);
|
||||
const last = backend.seen[backend.seen.length - 1];
|
||||
expect(last.url).toBe("/ssh/file_manager/ssh/downloadFileStream");
|
||||
expect(last.url).toBe("/plugin-api/file-manager/downloadFileStream");
|
||||
expect(last.headers.authorization).toBeUndefined();
|
||||
expect(last.headers.cookie).toBeUndefined();
|
||||
expect(last.headers["x-electron-app"]).toBe("true");
|
||||
@@ -952,7 +958,7 @@ describe("local-files upload boundary", () => {
|
||||
const handlers = localFiles.createLocalFileHandlers({
|
||||
net: fakeNet,
|
||||
shell: {},
|
||||
localBaseUrl: `http://127.0.0.1:${port}/ssh/file_manager`,
|
||||
localBaseUrl: `http://127.0.0.1:${port}/plugin-api/file-manager`,
|
||||
});
|
||||
const result = await handlers[localFiles.IPC.UPLOAD](fakeEvent, {
|
||||
transferId: "up-1",
|
||||
@@ -964,7 +970,7 @@ describe("local-files upload boundary", () => {
|
||||
headers: { Authorization: "Bearer leaked" },
|
||||
});
|
||||
expect(result.success).toBe(true);
|
||||
expect(received.url).toBe("/ssh/file_manager/ssh/uploadFileStream");
|
||||
expect(received.url).toBe("/plugin-api/file-manager/uploadFileStream");
|
||||
expect(received.headers?.authorization).toBeUndefined();
|
||||
expect(received.fields).toEqual({
|
||||
sessionId: "42",
|
||||
@@ -1006,7 +1012,7 @@ describe("local-files upload boundary", () => {
|
||||
const handlers = localFiles.createLocalFileHandlers({
|
||||
net: fakeNet,
|
||||
shell: {},
|
||||
localBaseUrl: `http://127.0.0.1:${port}/ssh/file_manager`,
|
||||
localBaseUrl: `http://127.0.0.1:${port}/plugin-api/file-manager`,
|
||||
});
|
||||
const withoutToken = await handlers[localFiles.IPC.UPLOAD](fakeEvent, {
|
||||
transferId: "up-auth-0",
|
||||
@@ -1105,7 +1111,7 @@ describe("local-files upload boundary", () => {
|
||||
const handlers = localFiles.createLocalFileHandlers({
|
||||
net: fakeNet,
|
||||
shell: {},
|
||||
localBaseUrl: `http://127.0.0.1:${port}/ssh/file_manager`,
|
||||
localBaseUrl: `http://127.0.0.1:${port}/plugin-api/file-manager`,
|
||||
});
|
||||
const results = await Promise.all(
|
||||
files.map((f) =>
|
||||
@@ -1131,7 +1137,7 @@ describe("local-files upload boundary", () => {
|
||||
const handlers = localFiles.createLocalFileHandlers({
|
||||
net: fakeNet,
|
||||
shell: {},
|
||||
localBaseUrl: "http://127.0.0.1:1/ssh/file_manager",
|
||||
localBaseUrl: "http://127.0.0.1:1/plugin-api/file-manager",
|
||||
});
|
||||
const result = await handlers[localFiles.IPC.UPLOAD](fakeEvent, {
|
||||
transferId: "up-2",
|
||||
@@ -1144,3 +1150,17 @@ describe("local-files upload boundary", () => {
|
||||
expect(result.error).toMatch(/Unknown transfer origin/);
|
||||
});
|
||||
});
|
||||
|
||||
describe("local-files transfer API path", () => {
|
||||
it("accepts only a /plugin-api/<id> path from the plugin", () => {
|
||||
const set = (
|
||||
localFiles as unknown as {
|
||||
setTransferApiPath: (path: unknown) => void;
|
||||
}
|
||||
).setTransferApiPath;
|
||||
expect(() => set("/plugin-api/file-manager")).not.toThrow();
|
||||
for (const bad of ["/users", "/plugin-api/../users", "https://x", 3]) {
|
||||
expect(() => set(bad)).toThrow(/Invalid transfer API path/);
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,124 @@
|
||||
import { createRequire } from "node:module";
|
||||
import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { afterEach, describe, expect, it } from "vitest";
|
||||
|
||||
const require = createRequire(import.meta.url);
|
||||
const customize = require("../../../../packaging/build/msi-shortcuts.cjs") as (
|
||||
path: string,
|
||||
) => Promise<void>;
|
||||
const { DOMParser } = require("@xmldom/xmldom");
|
||||
let dir: string;
|
||||
afterEach(async () => {
|
||||
if (dir) await rm(dir, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
const project = `<Wix><Product>
|
||||
<UIRef Id="WixUI_InstallDir"/>
|
||||
<UI><Publish Dialog="InstallScopeDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
|
||||
<Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Order="2">1</Publish>
|
||||
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="InstallScopeDlg">1</Publish></UI>
|
||||
<Feature><ComponentGroupRef Id="ProductComponents"/></Feature>
|
||||
<ComponentGroup><Component><File Id="mainExecutable">
|
||||
<Shortcut Id="desktopShortcut" Directory="DesktopFolder" Name="Termix" WorkingDirectory="APPLICATIONFOLDER" Advertise="yes" Icon="TermixIcon.exe"/>
|
||||
<Shortcut Id="startMenuShortcut" Directory="ProgramMenuFolder" Advertise="yes"/>
|
||||
</File></Component></ComponentGroup>
|
||||
</Product></Wix>`;
|
||||
|
||||
describe("MSI desktop shortcut option", () => {
|
||||
it("makes only the desktop shortcut conditional and connects both installation scopes to its page", async () => {
|
||||
dir = await mkdtemp(join(tmpdir(), "termix-msi-"));
|
||||
const file = join(dir, "project.wxs");
|
||||
await writeFile(file, project);
|
||||
await customize(file);
|
||||
const xml = await readFile(file, "utf8");
|
||||
const doc = new DOMParser().parseFromString(xml, "text/xml");
|
||||
const elements = (name: string) =>
|
||||
Array.from(doc.getElementsByTagName(name)) as Element[];
|
||||
const desktop = elements("Shortcut").find(
|
||||
(node) => node.getAttribute("Id") === "desktopShortcut",
|
||||
)!;
|
||||
expect(desktop.getAttribute("Target")).toBe("[#mainExecutable]");
|
||||
expect(desktop.getAttribute("Advertise")).toBeFalsy();
|
||||
expect((desktop.parentNode as Element).getAttribute("Id")).toBe(
|
||||
"TermixDesktopShortcut",
|
||||
);
|
||||
expect(elements("Condition")[0].textContent).toBe(
|
||||
'TERMIX_DESKTOP_SHORTCUT = "1"',
|
||||
);
|
||||
expect(
|
||||
elements("Shortcut")
|
||||
.find((node) => node.getAttribute("Id") === "startMenuShortcut")!
|
||||
.getAttribute("Advertise"),
|
||||
).toBe("yes");
|
||||
expect(
|
||||
elements("Publish").filter(
|
||||
(node) => node.getAttribute("Value") === "TermixShortcutDlg",
|
||||
),
|
||||
).toHaveLength(3);
|
||||
const installDir = elements("Publish").find(
|
||||
(node) =>
|
||||
node.getAttribute("Dialog") === "InstallDirDlg" &&
|
||||
node.getAttribute("Value") === "TermixShortcutDlg",
|
||||
)!;
|
||||
// Must run after WixUI_InstallDir's own VerifyReadyDlg event (Order 4).
|
||||
expect(Number(installDir.getAttribute("Order"))).toBeGreaterThan(4);
|
||||
expect(installDir.textContent).toBe(
|
||||
'WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID="1"',
|
||||
);
|
||||
expect(
|
||||
elements("Control")
|
||||
.find((node) => node.getAttribute("Type") === "CheckBox")!
|
||||
.getAttribute("Property"),
|
||||
).toBe("TERMIX_DESKTOP_SHORTCUT");
|
||||
});
|
||||
|
||||
it("accepts the installed electron-builder MSI template", async () => {
|
||||
const template = await readFile(
|
||||
require.resolve("app-builder-lib/templates/msi/template.xml"),
|
||||
"utf8",
|
||||
);
|
||||
const xml = require("ejs").render(
|
||||
template
|
||||
.replace(/{{/g, "<%")
|
||||
.replace(/}}/g, "%>")
|
||||
.replace(/\$\{([^}]+)}/g, "<%=$1%>"),
|
||||
{
|
||||
productName: "Termix",
|
||||
upgradeCode: "9A4E27D1-6F54-4B15-ABBD-54B194CB7200",
|
||||
version: "2.9.0",
|
||||
manufacturer: "Termix",
|
||||
compressionLevel: "high",
|
||||
installationDirectoryWixName: "Termix",
|
||||
iconPath: null,
|
||||
isRunAfterFinish: false,
|
||||
isAssisted: true,
|
||||
isPerMachine: false,
|
||||
programFilesId: "ProgramFiles64Folder",
|
||||
menuCategory: null,
|
||||
isCreateDesktopShortcut: true,
|
||||
isCreateStartMenuShortcut: true,
|
||||
dirs: "",
|
||||
files:
|
||||
'<Component Id="Main" Guid="*"><File Id="mainExecutable" Source="Termix.exe"><Shortcut Id="desktopShortcut" Directory="DesktopFolder" Name="Termix" Advertise="yes"/></File></Component>',
|
||||
},
|
||||
);
|
||||
dir = await mkdtemp(join(tmpdir(), "termix-msi-"));
|
||||
const file = join(dir, "project.wxs");
|
||||
await writeFile(file, xml);
|
||||
await customize(file);
|
||||
const result = await readFile(file, "utf8");
|
||||
expect(result.match(/Value="TermixShortcutDlg"/g)).toHaveLength(3);
|
||||
expect(result).toContain('RegistryValue Root="HKMU"');
|
||||
expect(result).toContain('<ComponentRef Id="TermixDesktopShortcut"/>');
|
||||
});
|
||||
|
||||
it("stops the build if the generated installer template changes", async () => {
|
||||
dir = await mkdtemp(join(tmpdir(), "termix-msi-"));
|
||||
const file = join(dir, "project.wxs");
|
||||
await writeFile(file, "<Wix/>");
|
||||
await expect(customize(file)).rejects.toThrow("Unexpected MSI template");
|
||||
expect(await readFile(file, "utf8")).toBe("<Wix/>");
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,36 @@
|
||||
import { createRequire } from "node:module";
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
const require = createRequire(import.meta.url);
|
||||
const { buildRdpFile, validateNativeRdpOptions } =
|
||||
require("../../../../electron/native-rdp.cjs") as {
|
||||
buildRdpFile: (options: Record<string, unknown>) => string;
|
||||
validateNativeRdpOptions: (options: Record<string, unknown>) => unknown;
|
||||
};
|
||||
|
||||
describe("native Windows RDP", () => {
|
||||
it("creates a credential-prompting RDP file without a password", () => {
|
||||
const result = buildRdpFile({
|
||||
host: "server.example.com",
|
||||
port: 3390,
|
||||
username: "alice",
|
||||
domain: "EXAMPLE",
|
||||
password: "must-not-be-written",
|
||||
});
|
||||
|
||||
expect(result).toContain("full address:s:server.example.com:3390");
|
||||
expect(result).toContain("username:s:EXAMPLE\\alice");
|
||||
expect(result).toContain("prompt for credentials:i:1");
|
||||
expect(result).not.toContain("must-not-be-written");
|
||||
});
|
||||
|
||||
it("rejects unsafe host and port values", () => {
|
||||
expect(() =>
|
||||
validateNativeRdpOptions({ host: "bad\r\nvalue" }),
|
||||
).not.toThrow();
|
||||
expect(() => validateNativeRdpOptions({ host: "server/path" })).toThrow();
|
||||
expect(() =>
|
||||
validateNativeRdpOptions({ host: "server", port: 70000 }),
|
||||
).toThrow();
|
||||
});
|
||||
});
|
||||
@@ -1,101 +0,0 @@
|
||||
import { execFileSync } from "node:child_process";
|
||||
import { createRequire } from "node:module";
|
||||
import { mkdtempSync, readFileSync, rmSync } from "node:fs";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import https from "node:https";
|
||||
import type { AddressInfo } from "node:net";
|
||||
import { afterAll, beforeAll, expect, it } from "vitest";
|
||||
|
||||
const require = createRequire(import.meta.url);
|
||||
const {
|
||||
createRemoteSyncFetch,
|
||||
} = require("../../../../electron/remote-sync-fetch.cjs");
|
||||
let server: https.Server;
|
||||
let origin: string;
|
||||
let directory: string;
|
||||
let redirectedRequests = 0;
|
||||
const config = { serverUrl: "", allowInvalidCertificate: false };
|
||||
const request = createRemoteSyncFetch(() => config);
|
||||
|
||||
beforeAll(async () => {
|
||||
directory = mkdtempSync(join(tmpdir(), "termix-sync-tls-"));
|
||||
const key = join(directory, "key.pem");
|
||||
const cert = join(directory, "cert.pem");
|
||||
execFileSync(
|
||||
"openssl",
|
||||
[
|
||||
"req",
|
||||
"-x509",
|
||||
"-newkey",
|
||||
"rsa:2048",
|
||||
"-nodes",
|
||||
"-keyout",
|
||||
key,
|
||||
"-out",
|
||||
cert,
|
||||
"-days",
|
||||
"1",
|
||||
"-subj",
|
||||
"/CN=localhost",
|
||||
],
|
||||
{ stdio: "ignore" },
|
||||
);
|
||||
server = https.createServer(
|
||||
{ key: readFileSync(key), cert: readFileSync(cert) },
|
||||
(req, res) => {
|
||||
if (req.url === "/redirect") {
|
||||
res.writeHead(302, { Location: `${origin}/redirect-target` });
|
||||
} else {
|
||||
if (req.url === "/redirect-target") redirectedRequests++;
|
||||
res.setHeader("Content-Type", "application/json");
|
||||
res.write(
|
||||
JSON.stringify({
|
||||
authorization: req.headers.authorization,
|
||||
method: req.method,
|
||||
}),
|
||||
);
|
||||
}
|
||||
res.end();
|
||||
},
|
||||
);
|
||||
await new Promise<void>((resolve) => server.listen(0, "127.0.0.1", resolve));
|
||||
origin = `https://127.0.0.1:${(server.address() as AddressInfo).port}`;
|
||||
config.serverUrl = `${origin}/termix`;
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
server?.closeAllConnections();
|
||||
if (server)
|
||||
await new Promise<void>((resolve) => server.close(() => resolve()));
|
||||
if (directory) rmSync(directory, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
it("rejects self-signed certificates until enabled, then preserves authenticated requests", async () => {
|
||||
await expect(request(`${origin}/users/me`)).rejects.toThrow();
|
||||
config.allowInvalidCertificate = true;
|
||||
const response = await request(`${origin}/users/me`, {
|
||||
headers: { Authorization: "Bearer dummy-token" },
|
||||
method: "POST",
|
||||
body: "{}",
|
||||
});
|
||||
expect(await response.json()).toEqual({
|
||||
authorization: "Bearer dummy-token",
|
||||
method: "POST",
|
||||
});
|
||||
config.allowInvalidCertificate = false;
|
||||
await expect(request(`${origin}/users/me`)).rejects.toThrow();
|
||||
});
|
||||
|
||||
it("does not apply an exception to another configured origin", async () => {
|
||||
config.allowInvalidCertificate = true;
|
||||
config.serverUrl = "https://another.example";
|
||||
await expect(request(`${origin}/sync/hosts`)).rejects.toThrow();
|
||||
config.serverUrl = origin;
|
||||
});
|
||||
|
||||
it("refuses redirects rather than carrying the TLS exception to another request", async () => {
|
||||
config.allowInvalidCertificate = true;
|
||||
await expect(request(`${origin}/redirect`)).rejects.toThrow();
|
||||
expect(redirectedRequests).toBe(0);
|
||||
});
|
||||
@@ -1,112 +0,0 @@
|
||||
import { readFileSync } from "node:fs";
|
||||
import { createRequire } from "node:module";
|
||||
import { resolve } from "node:path";
|
||||
import { runInNewContext } from "node:vm";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { deserializeSyncReferences } from "../../database/routes/sync-references.js";
|
||||
|
||||
const filename = resolve("electron/remote-sync.cjs");
|
||||
const localRequire = createRequire(filename);
|
||||
const { orderSyncWrites } = localRequire("./sync-write-order.cjs");
|
||||
const moduleStub = { exports: {} };
|
||||
const Engine = runInNewContext(
|
||||
readFileSync(filename, "utf8") + "\nRemoteSyncEngine;",
|
||||
{
|
||||
module: moduleStub,
|
||||
require: (name: string) => (name === "electron" ? {} : localRequire(name)),
|
||||
},
|
||||
);
|
||||
|
||||
type Row = {
|
||||
syncId: string;
|
||||
updatedAt: string;
|
||||
parentHostSyncId: string | null;
|
||||
};
|
||||
const local = "http://127.0.0.1:30001";
|
||||
const remote = "https://remote.example";
|
||||
|
||||
describe("nested host sync writes", () => {
|
||||
it.each([local, remote])(
|
||||
"copies parents before reparented children into %s",
|
||||
async (destination) => {
|
||||
const oldChild: Row = {
|
||||
syncId: "child",
|
||||
updatedAt: "2026-01-01",
|
||||
parentHostSyncId: null,
|
||||
};
|
||||
const parent: Row = {
|
||||
syncId: "parent",
|
||||
updatedAt: "2026-01-02",
|
||||
parentHostSyncId: null,
|
||||
};
|
||||
const newChild: Row = {
|
||||
...oldChild,
|
||||
updatedAt: "2026-01-02",
|
||||
parentHostSyncId: "parent",
|
||||
};
|
||||
const source = destination === local ? remote : local;
|
||||
const stores = new Map<string, Map<string, Row>>([
|
||||
[destination, new Map([["child", oldChild]])],
|
||||
[
|
||||
source,
|
||||
new Map([
|
||||
["parent", parent],
|
||||
["child", newChild],
|
||||
]),
|
||||
],
|
||||
]);
|
||||
const engine = new Engine(() => null);
|
||||
engine.localJwt = "local-token";
|
||||
engine.pullSide = async (url: string) => [...stores.get(url)!.values()];
|
||||
engine.pullTombstones = async () => [];
|
||||
const written: string[] = [];
|
||||
engine.pushRow = async (
|
||||
url: string,
|
||||
_token: string,
|
||||
entity: "hosts",
|
||||
row: Row,
|
||||
) => {
|
||||
await deserializeSyncReferences(entity, row, async (_type, id) =>
|
||||
stores.get(url)!.has(id) ? 1 : null,
|
||||
);
|
||||
stores.get(url)!.set(row.syncId, row);
|
||||
written.push(row.syncId);
|
||||
};
|
||||
await engine.syncEntity({
|
||||
entityType: "hosts",
|
||||
remoteBaseUrl: remote,
|
||||
remoteJwt: "remote-token",
|
||||
});
|
||||
expect(written).toEqual(["parent", "child"]);
|
||||
expect(stores.get(destination)!.get("child")!.parentHostSyncId).toBe(
|
||||
"parent",
|
||||
);
|
||||
written.length = 0;
|
||||
await engine.syncEntity({
|
||||
entityType: "hosts",
|
||||
remoteBaseUrl: remote,
|
||||
remoteJwt: "remote-token",
|
||||
});
|
||||
expect(written).toEqual([]);
|
||||
},
|
||||
);
|
||||
|
||||
it("rejects cyclic write dependencies before any writes are sent", () => {
|
||||
const writes = [
|
||||
{ baseUrl: local, row: { syncId: "a", parentHostSyncId: "b" } },
|
||||
{ baseUrl: local, row: { syncId: "b", parentHostSyncId: "a" } },
|
||||
];
|
||||
expect(() => orderSyncWrites("hosts", writes)).toThrow(
|
||||
"Cyclic parent host",
|
||||
);
|
||||
});
|
||||
|
||||
it("does not confuse writes to different destinations", () => {
|
||||
const writes = [
|
||||
{ baseUrl: local, row: { syncId: "a", parentHostSyncId: "b" } },
|
||||
{ baseUrl: remote, row: { syncId: "b", parentHostSyncId: "a" } },
|
||||
];
|
||||
expect(orderSyncWrites("hosts", writes)).toEqual(writes);
|
||||
expect(orderSyncWrites("snippets", writes)).toBe(writes);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user