fix: upload files to redirected RDP drives (#1356)

src/ui/tests/features/guacamole/GuacamoleToolbar.test.tsx

@@ -19,6 +19,7 @@ describe("GuacamoleToolbar Windows key", () => {
         sendMouse: vi.fn(),
         setClipboard: vi.fn(),
         getFilesystem: () => null,
+        uploadFile: async () => {},
         zoomIn: vi.fn(() => 1.25),
         zoomOut: vi.fn(() => 0.75),
         resetZoom: vi.fn(() => 1),
@@ -60,6 +61,7 @@ describe("GuacamoleToolbar Windows key", () => {
         sendMouse: vi.fn(),
         setClipboard: vi.fn(),
         getFilesystem: () => null,
+        uploadFile: async () => {},
         zoomIn,
         zoomOut,
         resetZoom,

src/ui/tests/features/guacamole/guacamole-file-drop.test.ts

@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 import {
+  canUploadToRdpDrive,
   getFileDropDisposition,
   hasDraggedFiles,
 } from "@/features/guacamole/guacamole-file-drop.ts";
@@ -14,4 +15,11 @@ describe("Guacamole file drop", () => {
     expect(getFileDropDisposition(["Files"], 1, false)).toBe("reject");
     expect(getFileDropDisposition(["Files"], 1, true)).toBe("upload");
   });
+
+  it("accepts an enabled RDP drive before a filesystem object is advertised", () => {
+    expect(canUploadToRdpDrive(true, true, false)).toBe(true);
+    expect(canUploadToRdpDrive(true, false, true)).toBe(true);
+    expect(canUploadToRdpDrive(true, false, false)).toBe(false);
+    expect(canUploadToRdpDrive(false, true, true)).toBe(false);
+  });
 });

src/ui/tests/features/guacamole/guacamole-filesystem.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from "vitest";
+import { describe, expect, it, vi } from "vitest";
 import {
   STREAM_INDEX_MIMETYPE,
   basename,
@@ -6,7 +6,10 @@ import {
   joinPath,
   parentPath,
   parseDirectoryIndex,
+  createClientFileStream,
+  type GuacamoleFileStreamClient,
 } from "../../../features/guacamole/guacamole-filesystem.js";
+import type Guacamole from "guacamole-common-js";
 
 describe("path helpers", () => {
   it("joins onto the root without doubling the separator", () => {
@@ -86,3 +89,19 @@ describe("parseDirectoryIndex", () => {
     expect(parseDirectoryIndex("{}", "/")).toEqual([]);
   });
 });
+
+describe("direct RDP upload", () => {
+  it("opens a connection-level file stream when no filesystem object is available", () => {
+    const stream = {} as Guacamole.OutputStream;
+    const client = {
+      createFileStream: vi.fn(() => stream),
+    } as GuacamoleFileStreamClient;
+    const file = new File(["hello"], "notes.txt", { type: "text/plain" });
+
+    expect(createClientFileStream(client, file)).toBe(stream);
+    expect(client.createFileStream).toHaveBeenCalledWith(
+      "text/plain",
+      "notes.txt",
+    );
+  });
+});