feat: turn session recording into a plugin (B13)

plugins/remote-desktop/src/backend/guacamole-server.ts

@@ -4,16 +4,33 @@ import {
   GuacamoleTokenService,
   type GuacamoleRecordingMetadata,
 } from "./token-service.js";
-import {
-  createCurrentSessionRecordingRepository,
-  getCurrentSettingValue,
-} from "../../../../src/backend/database/repositories/factory.js";
+import { getCurrentSettingValue } from "../../../../src/backend/database/repositories/factory.js";
 import { resolveGuacdOptions } from "../../../../src/backend/utils/guacd-config.js";
 import fs from "fs";
 import path from "path";
 
 const tokenService = GuacamoleTokenService.getInstance();
 
+/** The recordings.writer service, when the session-recording plugin provides it. */
+export interface RecordingsWriter {
+  createFinished: (input: {
+    hostId: number;
+    userId: string;
+    startedAt: string;
+    endedAt: string;
+    duration: number | null;
+    recordingPath: string;
+    protocol: string;
+    format: string;
+  }) => Promise<{ id: number }>;
+}
+
+let pluginRecordings: RecordingsWriter | null = null;
+
+export function setPluginRecordings(recordings: RecordingsWriter | null): void {
+  pluginRecordings = recordings;
+}
+
 function readGuacdOptions(): { host: string; port: number } {
   let dbUrl: string | undefined;
   try {
@@ -103,9 +120,17 @@ async function persistGuacamoleRecording(
     return;
   }
 
+  if (!pluginRecordings) {
+    guacLogger.warn(
+      "Session Recording plugin is off; guacamole recording not saved to the log",
+      { operation: "guac_recording_no_writer", hostId: recording.hostId },
+    );
+    return;
+  }
+
   const endedAt = new Date();
   const startedAt = new Date(recording.startedAt);
-  await createCurrentSessionRecordingRepository().create({
+  await pluginRecordings.createFinished({
     hostId: recording.hostId,
     userId: recording.userId,
     startedAt: startedAt.toISOString(),

plugins/remote-desktop/src/backend/index.ts

@@ -4,15 +4,24 @@ import {
   getGuacSessionInfo,
   handleGuacamoleUpgrade,
   restartGuacServer,
+  setPluginRecordings,
   startGuacamoleService,
   stopGuacamoleService,
   tokenService,
+  type RecordingsWriter,
 } from "./guacamole-server.js";
 import { startRemoteDesktopService } from "./routes.js";
 
 export async function activate(ctx: PluginContext) {
   setPluginSsh(ctx.ssh);
   ctx.disposables.add(() => setPluginSsh(null));
+
+  // Optional: without the session-recording plugin, a guacd recording is
+  // still made on disk but never gets a row, so it never shows in the list.
+  const recordings = ctx.services.get<RecordingsWriter>("recordings.writer");
+  setPluginRecordings("createFinished" in recordings ? recordings : null);
+  ctx.disposables.add(() => setPluginRecordings(null));
+
   await startGuacamoleService();
 
   startRemoteDesktopService(ctx.http.router());