fix: simplify host status to online/offline and keep it live without a refresh

src/ui/tests/sidebar/live-host-status.test.ts

@@ -0,0 +1,41 @@
+import { describe, expect, it } from "vitest";
+import type { Host, HostFolder } from "@/types/ui-types";
+import { withLiveHostStatus, withLiveStatus } from "@/sidebar/live-host-status";
+
+const host = (id: number, extra: Partial<Host> = {}) =>
+  ({ id: String(id), name: `h${id}`, online: false, ...extra }) as Host;
+
+const statuses: Record<number, "online" | "offline"> = {
+  1: "online",
+  2: "offline",
+};
+const getStatus = (id: number) => statuses[id] ?? "unknown";
+
+describe("withLiveStatus", () => {
+  it("copies live statuses into nested folders", () => {
+    const tree: HostFolder = {
+      name: "root",
+      children: [host(1), { name: "f", children: [host(2), host(3)] }],
+    };
+    const live = withLiveStatus(tree, getStatus);
+    const [first, folder] = live.children as [Host, HostFolder];
+    const [second, third] = folder.children as Host[];
+    expect(first).toMatchObject({ status: "online", online: true });
+    expect(second).toMatchObject({ status: "offline", online: false });
+    expect(third).toMatchObject({ status: "unknown", online: false });
+  });
+
+  it("gives a host with status checks off no status", () => {
+    const [live] = withLiveHostStatus(
+      [host(1, { statusCheckEnabled: false })],
+      getStatus,
+    );
+    expect(live.status).toBeUndefined();
+    expect(live.online).toBe(false);
+  });
+
+  it("keeps the same object when nothing changed", () => {
+    const same = host(1, { status: "online", online: true });
+    expect(withLiveHostStatus([same], getStatus)[0]).toBe(same);
+  });
+});

src/ui/tests/sidebar/tree/HostItem/HostItem.test.tsx

@@ -27,12 +27,11 @@ vi.mock("react-i18next", () => ({
 
 vi.mock("@/lib/ServerStatusContext", () => ({
   useHostStatus: () => null,
-  useHostStatusReason: () => null,
   useServerStatus: () => ({
     getStatus: () => "online",
     initialLoadComplete: true,
   }),
-  useServerStatusMeta: () => ({ initialLoadComplete: true, isLoading: false }),
+  useServerStatusMeta: () => ({ initialLoadComplete: true }),
 }));
 
 vi.mock("@/hooks/use-status-color-scheme", () => ({

src/ui/tests/sidebar/tree/HostItem/host-status-tooltip.test.ts

@@ -27,24 +27,24 @@ function makeHost(overrides: Partial<Host> = {}): Host {
 // not the key paths the translator falls back to when a resource is missing.
 const t = (key: string): string =>
   ({
-    "hosts.status.available": "Available",
-    "hosts.status.reachable": "Reachable, not authenticated",
+    "hosts.status.online": "Online",
+    "hosts.status.checking": "Checking",
     "hosts.status.offline": "Offline",
     "hosts.status.monitoringDisabled": "Monitoring disabled",
   })[key] ?? key;
 
 describe("buildStatusTooltip", () => {
-  it("returns the translated 'Available' label for online status", () => {
+  it("returns the translated 'Online' label for online status", () => {
     const host = makeHost();
     const tooltip = buildStatusTooltip(host, "online", t);
-    expect(tooltip).toContain("Available");
+    expect(tooltip).toContain("Online");
     expect(tooltip).not.toContain("hosts.status.");
   });
 
-  it("returns the translated 'Reachable, not authenticated' label for reachable status", () => {
+  it("returns 'Checking' before the host has been checked", () => {
     const host = makeHost();
-    const tooltip = buildStatusTooltip(host, "reachable", t);
-    expect(tooltip).toContain("Reachable, not authenticated");
+    const tooltip = buildStatusTooltip(host, "unknown", t);
+    expect(tooltip).toContain("Checking");
     expect(tooltip).not.toContain("hosts.status.");
   });
 
@@ -78,13 +78,13 @@ describe("buildStatusTooltip", () => {
     dispose();
     expect(tooltip).toContain("SSH");
     expect(tooltip).toContain("Demo Desktop");
-    expect(tooltip).toContain("Available");
+    expect(tooltip).toContain("Online");
   });
 
   it("returns just the status label when no protocols are enabled", () => {
     const host = makeHost({ enableSsh: false });
     const tooltip = buildStatusTooltip(host, "online", t);
-    expect(tooltip).toBe("Available");
+    expect(tooltip).toBe("Online");
   });
 
   it("does not render key paths when a translator is supplied", () => {